Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jackson-databind and jackson-annotations dependencies now coming from core #1167

Closed
Tracked by #191
ryanbogan opened this issue Dec 13, 2022 · 2 comments
Closed
Tracked by #191
Labels
dependencies Pull requests that update a dependency file v2.5.0 'Issues and PRs related to version v2.5.0'

Comments

@ryanbogan
Copy link
Member

jackson-databind and jackson-annotations were added as api dependencies in server of opensearch core. Therfore, all plugins now have these as transitive dependencies. Plugins that currently consume these dependencies directly will break while building unless the direct dependencies are removed. If your plugin does not consume jackson-databind or jackson-annotations directly, feel free to close the related issue in your plugin's repository.

Example of solution in security plugin: opensearch-project/security#2325

@minalsha minalsha added untriaged v2.5.0 'Issues and PRs related to version v2.5.0' labels Dec 13, 2022
@dai-chen dai-chen added dependencies Pull requests that update a dependency file and removed untriaged labels Dec 14, 2022
@ryanbogan ryanbogan added the bug Something isn't working label Dec 14, 2022
@penghuo penghuo removed the bug Something isn't working label Dec 14, 2022
@penghuo
Copy link
Collaborator

penghuo commented Dec 14, 2022

add comments at opensearch-project/opensearch-plugins#191 (comment). We need more clarification on this issue.

@penghuo
Copy link
Collaborator

penghuo commented Dec 14, 2022

SQL depend on jackson version defined in OpenSearch.
#1169

@penghuo penghuo closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

No branches or pull requests

4 participants