Do not register tenancy app if disabled in yml #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
+ Coverage 69.46% 71.17% +1.70%
==========================================
Files 96 96
Lines 2597 2598 +1
Branches 386 380 -6
==========================================
+ Hits 1804 1849 +45
+ Misses 699 649 -50
- Partials 94 100 +6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
RyanL1997 and
stephen-crawford
as code owners
RyanL1997
reviewed
Jul 24, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
…o/security-dashboards-plugin into dont-register-tenant-application
Signed-off-by: Derek Ho <dxho@amazon.com>
…o/security-dashboards-plugin into dont-register-tenant-application
cwperks
reviewed
Jul 25, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
cwperks
previously approved these changes
Jul 25, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
DarshitChanpura
approved these changes
Jul 25, 2024
stephen-crawford
approved these changes
Jul 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Do not register tenancy app if disabled in yml Signed-off-by: Derek Ho <dxho@amazon.com> * Adds a test Signed-off-by: Derek Ho <dxho@amazon.com> * Revert type and export Signed-off-by: Derek Ho <dxho@amazon.com> * Use constants Signed-off-by: Derek Ho <dxho@amazon.com> * Remove extra license field Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor with constants Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 0ed2cf2)
derek-ho
added a commit
that referenced
this pull request
Jul 25, 2024
* Do not register tenancy app if disabled in yml Signed-off-by: Derek Ho <dxho@amazon.com> * Adds a test Signed-off-by: Derek Ho <dxho@amazon.com> * Revert type and export Signed-off-by: Derek Ho <dxho@amazon.com> * Use constants Signed-off-by: Derek Ho <dxho@amazon.com> * Remove extra license field Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor with constants Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 0ed2cf2) Co-authored-by: Derek Ho <dxho@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doesn't register tenancy app if disabled in yml in the new side navigation. This was initially fixed in: #1960, but when the new left nav is enabled, tenancy is registered as an app (not just as part of the in-app navigation), so the code needs to change slightly to handle this case.
Category
Bug Fix
Why these changes are required?
Closes: #2056
What is the old behavior before changes and new behavior after changes?
Old behavior: in new left nav tenancy would show up even if disabled in yml
New behavior: in new left nav tenancy will not show up when disabled in yml
Issues Resolved
Closes: #2056
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.