Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on opensearch build repo libs from custom build.sh #2033

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Remove dependency on opensearch build repo libs from custom build.sh

Category

Bug Fix

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

Closes #2030

Testing

Test in local.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterzhuamazon
Copy link
Member Author

Result:

+ cleanup_all
+ rm -rf -- /tmp/tmpur7gcu_i/OpenSearch-Dashboards/plugins/securityDashboards
++ dirname /tmp/tmpur7gcu_i/OpenSearch-Dashboards/plugins/securityDashboards
+ ls -l /tmp/tmpur7gcu_i/OpenSearch-Dashboards/plugins
total 0
2024-07-15 21:19:41 INFO     Appended securityDashboards component in build manifest.
2024-07-15 21:19:41 INFO     Recording plugins artifact for securityDashboards: plugins/securityDashboards-2.15.0.zip (from /tmp/tmpur7gcu_i/securityDashboards/builds/plugins/securityDashboards-2.15.0.zip)

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (e35f7f7) to head (5bca1b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2033   +/-   ##
=======================================
  Coverage   70.61%   70.61%           
=======================================
  Files          97       97           
  Lines        2600     2600           
  Branches      380      380           
=======================================
  Hits         1836     1836           
  Misses        668      668           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derek-ho derek-ho merged commit b0d36ff into opensearch-project:main Jul 15, 2024
23 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 15, 2024
…2033)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit b0d36ff)
@peterzhuamazon peterzhuamazon deleted the fix-buildsh-cleanup branch July 15, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch bug Something isn't working release v2.16.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[BUG] Build.sh script failure
3 participants