Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Build.sh script failure #2030

Closed
derek-ho opened this issue Jul 15, 2024 · 2 comments · Fixed by #2033
Closed

[BUG] Build.sh script failure #2030

derek-ho opened this issue Jul 15, 2024 · 2 comments · Fixed by #2033
Assignees
Labels
bug Something isn't working triaged

Comments

@derek-ho
Copy link
Collaborator

What is the bug?
After introducing a custom script to build security dashboards plugin, builds started failing with a different error than cypress version mismatch.
How can one reproduce the bug?

2024-07-15 01:48:54 INFO     Building securityDashboards
2024-07-15 01:48:54 INFO     Executing "git init" in /tmp/tmpadrx3m18/securityDashboards
2024-07-15 01:48:54 INFO     Executing "git remote add origin https://github.com/opensearch-project/security-dashboards-plugin.git" in /tmp/tmpadrx3m18/securityDashboards
2024-07-15 01:48:54 INFO     Executing "git fetch --depth 1 origin main" in /tmp/tmpadrx3m18/securityDashboards
2024-07-15 01:48:55 INFO     Executing "git checkout FETCH_HEAD" in /tmp/tmpadrx3m18/securityDashboards
2024-07-15 01:48:55 INFO     Executing "git rev-parse HEAD" in /tmp/tmpadrx3m18/securityDashboards
2024-07-15 01:48:55 INFO     Checked out https://github.com/opensearch-project/security-dashboards-plugin.git@main into /tmp/tmpadrx3m18/securityDashboards at e35f7f767b69e88dbedab50b609ef84361572ae8
2024-07-15 01:48:55 INFO     Executing "bash /tmp/tmpadrx3m18/securityDashboards/scripts/build.sh -v 3.0.0 -p linux -a x64 -s false -o builds" in /tmp/tmpadrx3m18/securityDashboards
+++ realpath /tmp/tmpadrx3m18/securityDashboards/scripts/build.sh
++ dirname /tmp/tmpadrx3m18/securityDashboards/scripts/build.sh
+ SCRIPT_DIR=/tmp/tmpadrx3m18/securityDashboards/scripts
+ . /tmp/tmpadrx3m18/securityDashboards/scripts/../../../lib/shell/file_management.sh
/tmp/tmpadrx3m18/securityDashboards/scripts/build.sh: line 14: /tmp/tmpadrx3m18/securityDashboards/scripts/../../../lib/shell/file_management.sh: No such file or directory
2024-07-15 01:48:55 ERROR    ERROR: Command 'bash /tmp/tmpadrx3m18/securityDashboards/scripts/build.sh -v 3.0.0 -p linux -a x64 -s false -o builds' returned non-zero exit status 1.
2024-07-15 01:48:55 ERROR    Error building securityDashboards, retry with: ./build.sh manifests/3.0.0/opensearch-dashboards-3.0.0.yml --component securityDashboards

What is the expected behavior?
Builds successfully
What is your host/environment?

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Plugins

Do you have any screenshots?
No
Do you have any additional context?
It seems like the relative path is messed up, and would be different than the script being run in the build repo. After changing the relative path it should work.

@derek-ho derek-ho added bug Something isn't working untriaged labels Jul 15, 2024
@derek-ho derek-ho self-assigned this Jul 15, 2024
@cwperks cwperks added triaged and removed untriaged labels Jul 15, 2024
@cwperks
Copy link
Member

cwperks commented Jul 15, 2024

[Triage] Marking as triaged. Please submit a PR with a fix once its determined what the path should be in the script.

@derek-ho
Copy link
Collaborator Author

@peterzhuamazon helping out here from build repo side. This file doesn't exist if using a custom build script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
Status: ✅ Done
3 participants