[Backport 1.x] [OSCI][BUG] Fixing bug in icon-only buttons for showing info tooltip when hovered #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…when hovered (#1160) * fixing bug in icon-only buttons for showing info tooltip Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * Updating test snapshoots related to change in button_content.tsx Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * Updating chanelog.md regarding update in OuiButtonContent Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * updating button_content.tsx using recomendation of mantainer (include undefined in className instead of empty string) Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * updating test snapshoots for button_content.tsx Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * adding title prop to OuiIcon component, removing wrapping span element in buttonIcon and updating snapshots Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> * refactoring code for buttonIcon variable to keep more concise definition Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> --------- Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com> (cherry picked from commit 96af93e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
joshuarrrr
approved these changes
Jan 13, 2024
AMoo-Miki
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 96af93e from #1160.