Skip to content

Commit

Permalink
[OSCI][BUG] Fixing bug in icon-only buttons for showing info tooltip …
Browse files Browse the repository at this point in the history
…when hovered (#1160) (#1206)

* fixing bug in icon-only buttons for showing info tooltip

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>

* Updating test snapshoots related to change in button_content.tsx

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>

* Updating chanelog.md regarding update in OuiButtonContent

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>

* updating button_content.tsx using recomendation of mantainer (include undefined in className instead of empty string)

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>

* updating test snapshoots for button_content.tsx

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>

* adding title prop to OuiIcon component, removing wrapping span element in buttonIcon and updating snapshots

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>

* refactoring code for buttonIcon variable to keep more concise definition

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>

---------

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>
(cherry picked from commit 96af93e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent b3e8eec commit 0a35c09
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/components/button/button_content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export const OuiButtonContent: FunctionComponent<
className="ouiButtonContent__icon"
type={iconType}
size={iconSize}
title={textProps?.title}
color="inherit" // forces the icon to inherit its parent color
/>
);
Expand Down

0 comments on commit 0a35c09

Please sign in to comment.