Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROPOSAL] Replace sass-lint with stylelint #119

Open
BSFishy opened this issue Nov 10, 2022 · 1 comment · May be fixed by #949
Open

[PROPOSAL] Replace sass-lint with stylelint #119

BSFishy opened this issue Nov 10, 2022 · 1 comment · May be fixed by #949
Assignees
@BSFishy
Labels
technical debt

Comments

@BSFishy
Copy link
Contributor

BSFishy commented Nov 10, 2022

Is your feature request related to a problem? Please describe.

sass-lint is the linter we currently use for our SCSS files. It is very old, and as of writing this issue, the last release was published 4 years ago. Because of its age, sometimes issues arise, for example referencing modules that have been removed from Webpack for 2 major versions.

Describe the solution you'd like

A complete migration from sass-lint to Stylelint. As of writing, the last Stylelint release was published 7 days ago, and the project is significantly more active and it supports many more modern features. By replacing it, we will have more confidence that out linter won't break because it is unmaintained.
@BSFishy BSFishy added the enhancement New feature or request label Nov 10, 2022
@ashwin-pc
Copy link
Member

ashwin-pc commented Nov 11, 2022 •
edited
Loading

We have replaced the same in OSD a while ago with style lint. Ref: opensearch-project/OpenSearch-Dashboards#551

I think style lint is a valid alternative and is already in use in OSD. You can also refer to the PR's there if you face any issue with the migration

@BSFishy BSFishy mentioned this issue Nov 21, 2022
Closed
@BSFishy BSFishy mentioned this issue Mar 6, 2023
Open
@AbhishekReddy1127 AbhishekReddy1127 added technical debt and removed enhancement New feature or request labels Mar 10, 2023
@BSFishy BSFishy self-assigned this Mar 10, 2023
@gulderov gulderov mentioned this issue Aug 3, 2023
Closed
7 tasks
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
bump stylelint: 15.10.2 (opensearch-project#119)
f557ebb 
bump stylelint-config-standard-scss: 10.0.0

Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
bump postcss: 8.4.27 (opensearch-project#119)
7a9de5e 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
stylelint configs (opensearch-project#119)
62460ed 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
stylelint auto fix (opensearch-project#119)
b6366ab 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
remove stylelint config (opensearch-project#119)
a3b0e4c 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
stylelint config cleanup (opensearch-project#119)
7d80460 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
stylelint fix (opensearch-project#119)
b226e9c 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
stylelint fix src-docs (opensearch-project#119)
4bb9391 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
stylelint fix (opensearch-project#119)
ae29559 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
sass-lint cleanup (opensearch-project#119)
60a5680 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 3, 2023
@gulderov
scripts fix (opensearch-project#119)
ba7f671 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 4, 2023
@gulderov
stylelint fix (opensearch-project#119)
d06bbaa 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 4, 2023
@gulderov
removal of saas-lint comments (opensearch-project#119)
e3b0ff6 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 4, 2023
@gulderov
limit script to lint:style only (opensearch-project#119)
222f61b 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 4, 2023
@gulderov
prefer stylelint-disable-next-line over stylelint-disable-line (opens…
c725ad3 
…earch-project#119)

Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 4, 2023
@gulderov
sass-lint cleanup (opensearch-project#119)
6d6e6f7 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 4, 2023
@gulderov
rename scripts (opensearch-project#119)
5154f25 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
@gulderov gulderov linked a pull request Aug 4, 2023 that will close this issue
Open
7 tasks
gulderov added a commit to gulderov/oui that referenced this issue Aug 4, 2023
@gulderov
add script lint-style-fix (opensearch-project#119)
b120590 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 4, 2023
@gulderov
update changelog (opensearch-project#119)
0e5ba98 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 9, 2023
@gulderov
quotes (opensearch-project#119)
16e2dad 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 24, 2023
@gulderov
packages update (opensearch-project#119)
870a9db 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Aug 24, 2023
@gulderov
Merge branch 'main' into stylelint (opensearch-project#119)
8f0d289 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov added a commit to gulderov/oui that referenced this issue Sep 8, 2023
@gulderov
stylelint fix (opensearch-project#119)
d2eb2e1 
Signed-off-by: Danila Gulderov <danila@gulderov.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BSFishy BSFishy

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace sass-lint with stylelint gulderov/oui
3 participants
@BSFishy @ashwin-pc @AbhishekReddy1127