removal of saas-lint comments (opensearch-project#119)

Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov · Aug 3, 2023 · e3b0ff6 · e3b0ff6
1 parent d06bbaa
commit e3b0ff6
Show file tree

Hide file tree

Showing 122 changed files with 65 additions and 245 deletions.
diff --git a/src-docs/src/components/guide_components.scss b/src-docs/src/components/guide_components.scss
@@ -16,7 +16,7 @@ $guideZLevelHighest: $ouiZLevel9 + 1000;
 $elasticLogoTextLight: #FFF;
 $elasticLogoTextDark: #1C1E23;
 
-#guide { // sass-lint:disable-line no-ids
+#guide {
   display: flex;
   flex-direction: column;
   min-height: 100vh;
@@ -31,7 +31,7 @@ $elasticLogoTextDark: #1C1E23;
 .ouiBody--headerIsFixed--double {
   @include ouiHeaderAffordForFixed($ouiHeaderHeightCompensation * 2);
 
-  #guide { // sass-lint:disable-line no-ids
+  #guide {
     min-height: calc(100vh - #{$ouiHeaderHeightCompensation * 2});
   }
 
@@ -100,7 +100,7 @@ $elasticLogoTextDark: #1C1E23;
 .guideDemo__highlightLayout--playground > div:not(.ouiPage) {
   height: 100%;
   width: 100%;
-  padding: 0 !important; // sass-lint:disable-line no-important
+  padding: 0 !important;
 
   > .ouiPage--grow {
     height: 100%;
@@ -137,14 +137,12 @@ $elasticLogoTextDark: #1C1E23;
   padding: $ouiSize;
 }
 
-// sass-lint:disable no-important
 .guideDemo__textLines {
   background-image: linear-gradient($ouiFocusBackgroundColor 1px, transparent 1px) !important;
   background-size: 100% 8px !important;
   background-position-y: 2px;
 }
 
-// sass-lint:disable no-important
 .guideDemo__textLines--s {
   background-image: linear-gradient($ouiFocusBackgroundColor 1px, transparent 1px) !important;
   background-size: 100% 7px !important;
@@ -350,17 +348,16 @@ $elasticLogoTextDark: #1C1E23;
   min-width: 200px;
   flex-basis: 100% !important;
 
-  // sass-lint:disable-block mixins-before-declarations
   @include ouiBreakpoint('s', 'm') {
-    flex-basis: 45% !important; // sass-lint:disable-line no-important
+    flex-basis: 45% !important;
   }
 
   @include ouiBreakpoint('l') {
-    flex-basis: 30% !important; // sass-lint:disable-line no-important
+    flex-basis: 30% !important;
   }
 
   @include ouiBreakpoint('xl') {
-    flex-basis: 22% !important; // sass-lint:disable-line no-important
+    flex-basis: 22% !important;
   }
 }
 
@@ -460,7 +457,6 @@ $elasticLogoTextDark: #1C1E23;
 }
 
 .guideHome__footerLogo {
-  // sass-lint:disable-block no-important
   vertical-align: middle;
   display: inline-block !important;
   margin-bottom: 0 !important;

diff --git a/src-docs/src/components/guide_section/_guide_section.scss b/src-docs/src/components/guide_section/_guide_section.scss
@@ -40,5 +40,5 @@
 }
 
 .guideSectionTabs__tab {
-  font-weight: $ouiFontWeightMedium !important; // sass-lint:disable-line no-important
+  font-weight: $ouiFontWeightMedium !important;
 }
diff --git a/src-docs/src/services/playground/_playground_compiler.scss b/src-docs/src/services/playground/_playground_compiler.scss
@@ -11,6 +11,6 @@
 
 .playgroundWrapper {
   > div {
-    display: block !important; // sass-lint:disable-line no-important
+    display: block !important;
   }
 }
diff --git a/src-docs/src/theme_dark.scss b/src-docs/src/theme_dark.scss
@@ -9,7 +9,6 @@
  * GitHub history for details.
  */
 
-// sass-lint:disable no-url-domains, no-url-protocols
 @import 'https://fonts.googleapis.com/css?family=Roboto+Mono:400,400i,700,700i';
 @import 'https://rsms.me/inter/inter-ui.css';
 @import '../../src/theme_dark';

diff --git a/src-docs/src/theme_light.scss b/src-docs/src/theme_light.scss
@@ -9,7 +9,6 @@
  * GitHub history for details.
  */
 
-// sass-lint:disable no-url-domains, no-url-protocols
 @import 'https://fonts.googleapis.com/css?family=Roboto+Mono:400,400i,700,700i';
 @import 'https://rsms.me/inter/inter-ui.css';
 @import '../../src/theme_light';

diff --git a/src-docs/src/theme_next_dark.scss b/src-docs/src/theme_next_dark.scss
@@ -9,7 +9,6 @@
  * GitHub history for details.
  */
 
-// sass-lint:disable no-url-domains, no-url-protocols
 @import 'https://fonts.googleapis.com/css2?family=Source+Code+Pro:ital,wght@0,400;0,600;0,700;1,400;1,600;1,700&family=Source+Sans+3:ital,wght@0,400;0,600;0,700;1,400;1,600;1,700&display=swap';
 @import '../../src/theme_next_dark';
 @import './components/guide_components';

diff --git a/src-docs/src/theme_next_light.scss b/src-docs/src/theme_next_light.scss
@@ -9,7 +9,6 @@
  * GitHub history for details.
  */
 
-// sass-lint:disable no-url-domains, no-url-protocols
 @import 'https://fonts.googleapis.com/css2?family=Source+Code+Pro:ital,wght@0,400;0,600;0,700;1,400;1,600;1,700&family=Source+Sans+3:ital,wght@0,400;0,600;0,700;1,400;1,600;1,700&display=swap';
 @import '../../src/theme_next_light';
 @import './components/guide_components';

diff --git a/src-docs/src/views/guidelines/index.scss b/src-docs/src/views/guidelines/index.scss
@@ -33,7 +33,6 @@
   font-size: $ouiFontSizeS;
 }
 
-// sass-lint:disable no-important
 .guidelineColor__title {
   color: $ouiColorMediumShade !important;
 }
@@ -79,12 +78,10 @@
   background: shade($ouiColorDanger, 30%);
 }
 
-// sass-lint:disable no-color-literals
 .guideSass__swatch--primaryLight {
   background: #0079A5;
 }
 
-// sass-lint:disable no-color-literals
 .guideSass__swatch--primaryDark {
   background: #4DA1C0;
 }
@@ -307,15 +304,13 @@
   border-left: $ouiBorderThick;
 }
 
-// sass-lint:disable no-color-literals
 .guideSass__themedBox--light {
   border-color: #0079A5;
   background: tint(#0079A5, 90%);
   color: #333;
 }
 
 .guideSass__themedBox--dark {
-  // sass-lint:disable no-color-literals
   border-color: #4DA1C0;
   background: shade(#4DA1C0, 70%);
   color: #FFF;

diff --git a/src-docs/src/views/suggest/_global_filter_group.scss b/src-docs/src/views/suggest/_global_filter_group.scss
@@ -16,7 +16,6 @@
   margin-top: $ouiSizeXS;
 }
 
-// sass-lint:disable quotes
 .globalFilterGroup__branch {
   padding: $ouiSize $ouiSize $ouiSizeS $ouiSizeS;
   background-repeat: no-repeat;

diff --git a/src-docs/src/views/suggest/_saved_queries.scss b/src-docs/src/views/suggest/_saved_queries.scss
@@ -39,5 +39,5 @@
   max-height: inherit; // Fixes overflow for applied max-height
   // Left/Right padding is calculated to match the left alignment of the
   // popover text and buttons
-  padding: ($ouiSizeM / 2) $ouiSizeXS !important; // sass-lint:disable-line no-important
+  padding: ($ouiSizeM / 2) $ouiSizeXS !important;
 }
diff --git a/src/components/accessibility/_skip_link.scss b/src/components/accessibility/_skip_link.scss
@@ -10,10 +10,10 @@
  */
 
 .ouiSkipLink {
-  transition: none !important; // sass-lint:disable-line no-important
+  transition: none !important;
 
   &:focus {
-    animation: none !important; // sass-lint:disable-line no-important
+    animation: none !important;
   }
 
   // Set positions on focus only as to no override screenReaderOnly position

diff --git a/src/components/accordion/_accordion.scss b/src/components/accordion/_accordion.scss
@@ -84,8 +84,6 @@
   opacity: 0;
   overflow: hidden;
   transform: translatez(0);
-
-  // sass-lint:disable-block indentation
   transition:
     height $ouiAnimSpeedNormal $ouiAnimSlightResistance,
     opacity $ouiAnimSpeedNormal $ouiAnimSlightResistance;

diff --git a/src/components/aspect_ratio/_aspect_ratio.scss b/src/components/aspect_ratio/_aspect_ratio.scss
@@ -13,7 +13,6 @@
   position: relative;
 
   > * {
-    // sass-lint:disable-block no-important
     position: absolute !important;
     top: 0 !important;
     left: 0 !important;

diff --git a/src/components/badge/_badge.scss b/src/components/badge/_badge.scss
@@ -32,7 +32,6 @@
   text-align: left;
 
   &.ouiBadge-isDisabled {
-    // sass-lint:disable-block no-important
     // Using !important to override inline styles
     color: makeHighContrastColor($ouiButtonColorDisabled, $ouiButtonColorDisabled, 2) !important;
     background-color: $ouiButtonColorDisabled !important;
@@ -91,7 +90,7 @@
 
     .ouiBadge__icon {
       // Remove margins from icon itself so that focus state doesn't include that space
-      margin: 0 !important; // sass-lint:disable-line no-important
+      margin: 0 !important;
     }
   }
 

diff --git a/src/components/bottom_bar/_bottom_bar.scss b/src/components/bottom_bar/_bottom_bar.scss
@@ -19,7 +19,6 @@
   background: $ouiHeaderDarkBackgroundColor;
   color: $ouiColorGhost;
 
-  // sass-lint:disable-block mixins-before-declarations
   @include ouiCanAnimate {
     animation: ouiBottomBarAppear $ouiAnimSpeedSlow $ouiAnimSlightResistance;
   }

diff --git a/src/components/breadcrumbs/_breadcrumbs.scss b/src/components/breadcrumbs/_breadcrumbs.scss
@@ -32,7 +32,7 @@
     color: $ouiTextSubduedColor;
 
     &:hover {
-      color: $ouiBreadCrumbHoverColor !important; // sass-lint:disable-line no-important
+      color: $ouiBreadCrumbHoverColor !important;
     }
   }
 }
@@ -44,16 +44,16 @@
 .ouiBreadcrumb--collapsed {
   flex-shrink: 0;
   color: $ouiBreadcrumbCollapsedLink;
-  vertical-align: top !important; // sass-lint:disable-line no-important
+  vertical-align: top !important;
 }
 
 .ouiBreadcrumb__collapsedLink:hover {
-  color: $ouiBreadCrumbHoverColor !important; // sass-lint:disable-line no-important
+  color: $ouiBreadCrumbHoverColor !important;
 }
 
 .ouiBreadcrumbs__inPopover .ouiBreadcrumb--last {
   font-weight: $ouiFontWeightRegular;
-  color: $ouiColorDarkShade !important; // sass-lint:disable-line no-important
+  color: $ouiColorDarkShade !important;
 }
 
 .ouiBreadcrumbs--truncate {

diff --git a/src/components/button/_button.scss b/src/components/button/_button.scss
@@ -10,7 +10,6 @@
  */
 
 // This file has lots of modifiers and is somewhat nesty by nature
-// sass-lint:disable nesting-depth
 
 // Our base button
 .ouiButton {

diff --git a/src/components/button/button_empty/_button_empty.scss b/src/components/button/button_empty/_button_empty.scss
@@ -20,8 +20,6 @@
   border-color: transparent;
   background-color: transparent;
   box-shadow: none;
-
-  // sass-lint:disable-block no-important
   transform: none !important; /* 1 */
   animation: none !important; /* 1 */
   transition-timing-function: ease-in; /* 2 */

diff --git a/src/components/button/button_group/_button_group.scss b/src/components/button/button_group/_button_group.scss
@@ -42,7 +42,7 @@
 
 .ouiButtonGroup--compressed {
   .ouiButtonGroup__buttons {
-    box-shadow: none !important; // sass-lint:disable-line no-important
+    box-shadow: none !important;
     border-radius: $ouiFormControlCompressedBorderRadius;
     background-color: $ouiFormBackgroundColor;
     height: $ouiFormControlCompressedHeight;

diff --git a/src/components/button/button_group/_button_group_button.scss b/src/components/button/button_group/_button_group_button.scss
@@ -14,7 +14,6 @@
   @include ouiFont;
   @include ouiFontSize;
 
-  // sass-lint:disable-block indentation
   transition: background-color $ouiAnimSpeedNormal ease-in-out,
               border-color $ouiAnimSpeedNormal ease-in-out,
               color $ouiAnimSpeedNormal ease-in-out;

diff --git a/src/components/button/button_icon/_button_icon.scss b/src/components/button/button_icon/_button_icon.scss
@@ -10,7 +10,6 @@
  */
 
 // This file has lots of modifiers and is somewhat nesty by nature
-// sass-lint:disable nesting-depth
 
 .ouiButtonIcon {
   @include ouiButton;
@@ -31,7 +30,7 @@
   }
 
   &.ouiButtonIcon--empty {
-    box-shadow: none !important; // sass-lint:disable-line no-important
+    box-shadow: none !important;
     border: none;
   }
 

diff --git a/src/components/card/_card.scss b/src/components/card/_card.scss
@@ -24,7 +24,6 @@
   min-height: 1px; /* 2 */
 
   &.ouiCard-isDisabled {
-    // sass-lint:disable-block no-important
     cursor: not-allowed !important; // duplicate property due to Chrome bug
     transform: none !important;
     box-shadow: none !important;
@@ -140,7 +139,7 @@
         // IF both exist, position the icon centered on top of image
         + .ouiCard__icon {
           transform: translate(-50%, -75%); // Fallback for IE as it doesn't accept calcs in translates
-          transform: translate(-50%, calc(-50% + #{$paddingAmount * -1})); // sass-lint:disable-line no-duplicate-properties
+          transform: translate(-50%, calc(-50% + #{$paddingAmount * -1}));
         }
       }
     }
@@ -192,7 +191,7 @@
 @each $name, $color in $ouiCardSelectButtonBorders {
   .ouiCard--isSelectable--#{$name}.ouiCard-isSelected:not(.ouiCard-isDisabled) {
     // Override .ouiPanel.has--Border
-    border-color: $color !important; // sass-lint:disable-line no-important
+    border-color: $color !important;
   }
 }
 
@@ -232,8 +231,6 @@
   // otherwise the button tag won't properly align contents to top
   &.ouiCard--hasIcon {
     flex-direction: row;
-
-    // sass-lint:disable-block no-important
     align-items: flex-start !important; /* 3 */
 
     .ouiCard__top,

diff --git a/src/components/card/_mixins.scss b/src/components/card/_mixins.scss
@@ -13,7 +13,7 @@
   position: absolute;
   bottom: 0;
   left: 0;
-  height: $ouiCardBottomNodeHeight !important;  // sass-lint:disable-line no-important -- To override .ouiButtonEmpty--xSmall
+  height: $ouiCardBottomNodeHeight !important;  // To override .ouiButtonEmpty--xSmall
   width: 100%;
   overflow: hidden;
 

diff --git a/src/components/code/_code_block.scss b/src/components/code/_code_block.scss
@@ -60,7 +60,6 @@
     inset: 0;
 
     .ouiCodeBlock__pre {
-      // sass-lint:disable-block no-important
       padding: $ouiSizeXL !important;
     }
 

diff --git a/src/components/collapsible_nav/_collapsible_nav.scss b/src/components/collapsible_nav/_collapsible_nav.scss
@@ -12,5 +12,5 @@
 // Extends <OuiFlyout>
 
 .ouiCollapsibleNav:not([class*='push']) {
-  z-index: $ouiZNavigation !important; // sass-lint:disable-line no-important
+  z-index: $ouiZNavigation !important;
 }
diff --git a/src/components/collapsible_nav/collapsible_nav_group/_collapsible_nav_group.scss b/src/components/collapsible_nav/collapsible_nav_group/_collapsible_nav_group.scss
@@ -33,7 +33,7 @@
   // Forcing better contrast of focus state on OuiAccordion toggle icon
   .ouiCollapsibleNavGroup__heading:focus .ouiAccordion__iconWrapper {
     color: $ouiCollapsibleNavGroupDarkHighContrastColor;
-    animation-name: ouiCollapsibleNavGroupDarkFocusRingAnimate !important; // sass-lint:disable-line no-important
+    animation-name: ouiCollapsibleNavGroupDarkFocusRingAnimate !important;
   }
 
   .ouiCollapsibleNavGroup__title {

diff --git a/src/components/color_picker/_color_picker.scss b/src/components/color_picker/_color_picker.scss
@@ -38,11 +38,9 @@
 
 .ouiColorPicker__popoverPanel--pickerOnly {
   // Override of OuiPanel padding
-  // sass-lint:disable no-important
   padding-bottom: 0 !important;
 }
 
-// sass-lint:disable no-important
 .ouiColorPicker__input--inGroup {
   height: $ouiFormControlLayoutGroupInputHeight !important;
   box-shadow: none !important;