-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1137 - Adding query_image to Neural query #1138
Conversation
Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>
Thanks. If you can, please help make sure we don't break it via code generation. I see |
Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>
@dblock , I manually added the changes into NeuralQuery in this project. That link that you send me is for another project. How are these projects related ? |
Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>
@Xtansia is working on replacing all of these hand-rolled classes with a code generator that uses the spec in https://github.com/opensearch-project/opensearch-api-specification, beginning with #366. |
Hello @Xtansia & @dblock , I reviewed the existing schema definition and executed the generator.
I tried merging into the original file the Neural definition but then failed becase of the format binary not recognized:
Since the query_image is a String with a image in Base64 encoded format, seems safe to remove the format. |
@urinud Thanks for looking into this. I didn't know that |
Certainly. We have a whole guide in that repo! https://github.com/opensearch-project/opensearch-api-specification/blob/main/TESTING_GUIDE.md.
It LGTM, leaving it to @Xtansia to review/merge. |
@Xtansia , are we good with these changes in this project ? |
* Fixes #1137 Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com> * Adds missing documentation. Added changelog Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com> * Added deserialization test Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com> --------- Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com> Co-authored-by: uri.nudelman <uriel.nudelman@offerup.com> (cherry picked from commit 7b3719b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fixes #1137 * Adds missing documentation. Added changelog * Added deserialization test --------- (cherry picked from commit 7b3719b) Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: uri.nudelman <uriel.nudelman@offerup.com>
Description
Fixes missing field for query_image in Neural Query. See Neural query.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.