Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add query_image to Neural query #1137

Closed
urinud opened this issue Aug 13, 2024 · 1 comment · Fixed by #1138
Closed

[FEATURE] Add query_image to Neural query #1137

urinud opened this issue Aug 13, 2024 · 1 comment · Fixed by #1138
Labels
enhancement New feature or request untriaged

Comments

@urinud
Copy link
Contributor

urinud commented Aug 13, 2024

Is your feature request related to a problem?

Server side of Neural Query has an option to query_image which is not available in Java Client implementation.

What solution would you like?

Add to NeuralQuery class imageQuery field and its corresponding serialization.

What alternatives have you considered?

Create a local class, inherit and use it instead of the existing one. But its better to collaborate with the project.

Do you have any additional context?

None.
@urinud urinud added enhancement New feature or request untriaged labels Aug 13, 2024
urinud pushed a commit to urinud/opensearch-java that referenced this issue Aug 13, 2024
@uriofferup
Fixes opensearch-project#1137
4f2b98d 
Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>
@urinud urinud mentioned this issue Aug 13, 2024
Merged
Xtansia pushed a commit that referenced this issue Aug 15, 2024
@urinud @uriofferup
Fixes #1137 - Adding query_image to Neural query (#1138)
7b3719b 
* Fixes #1137

Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>

* Adds missing documentation. Added changelog

Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>

* Added deserialization test

Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>

---------

Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>
Co-authored-by: uri.nudelman <uriel.nudelman@offerup.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Aug 15, 2024
@github-actions @uriofferup
Fixes #1137 - Adding query_image to Neural query (#1138)
c433a8d 
* Fixes #1137

Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>

* Adds missing documentation. Added changelog

Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>

* Added deserialization test

Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>

---------

Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>
Co-authored-by: uri.nudelman <uriel.nudelman@offerup.com>
(cherry picked from commit 7b3719b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this issue Aug 15, 2024
@opensearch-trigger-bot @github-actions @uriofferup
Fixes #1137 - Adding query_image to Neural query (#1138) (#1139)
1b13ee2 
* Fixes #1137



* Adds missing documentation. Added changelog



* Added deserialization test



---------



(cherry picked from commit 7b3719b)

Signed-off-by: uri.nudelman <uriel.nudelman@offerup.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: uri.nudelman <uriel.nudelman@offerup.com>
@Xtansia
Copy link
Collaborator

Xtansia commented Aug 27, 2024

v2.14.0 has been released and includes the fix for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1137 - Adding query_image to Neural query urinud/opensearch-java
2 participants
@Xtansia @urinud