Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reuse specs finder #1411

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Jun 17, 2024

Description

Extract the ci_groups_finder logic to test_finder.sh so that Jenkins workflow can reuse the CI groups to organize OSD test cases.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe
Copy link
Member Author

@peterzhuamazon Would you like to take a look on the changes within test_finder.sh file?

@peterzhuamazon peterzhuamazon marked this pull request as draft June 17, 2024 18:31
@peterzhuamazon
Copy link
Member

Convert back to draft due to this:
opensearch-project/opensearch-build#4784 (comment)

@SuZhou-Joe SuZhou-Joe marked this pull request as ready for review June 18, 2024 10:20
@peterzhuamazon peterzhuamazon changed the base branch from 2.x to 2.15 June 21, 2024 22:26
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jun 22, 2024

Adding new changes and test with:

@peterzhuamazon
Copy link
Member

Adding more timeouts to resolve the embed.js issues.

@peterzhuamazon
Copy link
Member

Thanks @SuZhou-Joe !

@peterzhuamazon peterzhuamazon merged commit 463749c into opensearch-project:2.15 Jun 22, 2024
108 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 22, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 463749c)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 22, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 463749c)
peterzhuamazon pushed a commit that referenced this pull request Jun 22, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 463749c)

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
peterzhuamazon pushed a commit that referenced this pull request Jun 22, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 463749c)

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants