Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport main] Add permission to allow copying to clipboard #1283

Merged
merged 1 commit into from
May 14, 2024
Merged

[Backport main] Add permission to allow copying to clipboard #1283

merged 1 commit into from
May 14, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 64959fa from #1281

@SuZhou-Joe
Copy link
Member

SuZhou-Joe commented May 8, 2024 •
edited
Loading

@kavilla @abbyhu2000 Unfortunately, the copy test case still failed. Seems the config does not take effect.

image

@abbyhu2000 @SuZhou-Joe
add permission to allow copying to clipboard (#1281)
3852ca2 
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js
Issues Resolved

resolves #1081

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 64959fa)
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-1281-to-main branch from 6a48ecb to 3852ca2 Compare May 8, 2024 06:09
@SuZhou-Joe
Copy link
Member

Seems the test passed in jenkins CI, which is using electron to run the Cypress test. I will approve this PR for that. But for Github CI, which is using Chromium, still need to find a approach to fix. #1298 for track.

@SuZhou-Joe SuZhou-Joe merged commit 5c156d1 into main May 14, 2024
37 of 45 checks passed
@github-actions github-actions bot deleted the backport/backport-1281-to-main branch May 14, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@kavilla kavilla kavilla approved these changes

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuZhou-Joe @kavilla @abbyhu2000