Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Test copying links in Safari is flaky #1081

Closed
gaobinlong opened this issue Feb 8, 2024 · 1 comment · Fixed by #1281
Closed

[BUG] Test copying links in Safari is flaky #1081

gaobinlong opened this issue Feb 8, 2024 · 1 comment · Fixed by #1281
Labels
bug Something isn't working v2.12.0

Comments

@gaobinlong
Copy link
Contributor

gaobinlong commented Feb 8, 2024 •
edited
Loading

What is the bug?

The cypress test here is flaky, sometimes it runs failed with error NotAllowedError: Read permission denied. , see the detail here: https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/7637122802/job/20954769803.

The reason maybe that when executing win.navigator.clipboard.readText(), read permission on the clipboard is not granted, here's the document about accessing clipboard: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Interact_with_the_clipboard.

How can one reproduce the bug?

Running that test in Safari may reproduce.

What is the expected behavior?

Fix the flaky test.

What is your host/environment?

Safari browser.

Do you have any screenshots?

image

Do you have any additional context?

The cypress test was introduced in this PR: #940
@gaobinlong gaobinlong added bug Something isn't working untriaged labels Feb 8, 2024
@gaobinlong
Copy link
Contributor Author

@leanneeliatra , could you help to take a look?

@xluo-aws xluo-aws changed the title [BUG] Test copying links in Safari if flaky [BUG] Test copying links in Safari is flaky Feb 8, 2024
@abbyhu2000 abbyhu2000 mentioned this issue May 7, 2024
Merged
1 task
@kavilla kavilla linked a pull request May 7, 2024 that will close this issue
Add permission to allow copying to clipboard #1281
Merged
1 task
kavilla pushed a commit that referenced this issue May 7, 2024
@abbyhu2000
add permission to allow copying to clipboard (#1281)
64959fa 
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js
Issues Resolved

resolves #1081

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue May 7, 2024
@abbyhu2000 @github-actions
add permission to allow copying to clipboard (#1281)
23acd19 
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js
Issues Resolved

resolves #1081

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 64959fa)
opensearch-trigger-bot bot pushed a commit that referenced this issue May 7, 2024
@abbyhu2000 @github-actions
add permission to allow copying to clipboard (#1281)
050bab6 
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js
Issues Resolved

resolves #1081

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 64959fa)
SuZhou-Joe pushed a commit that referenced this issue May 8, 2024
@abbyhu2000 @SuZhou-Joe
add permission to allow copying to clipboard (#1281)
3852ca2 
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js
Issues Resolved

resolves #1081

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 64959fa)
SuZhou-Joe pushed a commit that referenced this issue May 14, 2024
@opensearch-trigger-bot @abbyhu2000
add permission to allow copying to clipboard (#1281) (#1282)
a168382 
Add permission for copying link to clipboard in cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js
Issues Resolved

resolves #1081

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 64959fa)

Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add permission to allow copying to clipboard abbyhu2000/opensearch-dashboards-functional-test
3 participants
@gaobinlong @ashwin-pc @xluo-aws