Integration tests for broken safari link

[leanneeliatra]

Description

Tests that when the link is copyed in Safari, it is copyed successfully and can be visited.
When visiting Discover > Copy link

Issues Resolved

Integration tests for the associated bugfix:
[BUG] Share > Copy link broken in Safari #1716

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ruanyl]

Hi @leanneeliatra, could you convert this PR to "draft" if it is "IN PROGRESS"?

[leanneeliatra]

This PR was closed accidentally, it is now reopened.

[leanneeliatra]

Tests are passing locally

[leanneeliatra]

For testing locally I am testing this in safari using: https://docs.cypress.io/guides/guides/launching-browsers#WebKit-Experimental (WebKit is available only via an experimental feature of Cypress). Given that this is experimental, it cannot be merged into the CI pipeline.

[leanneeliatra]

Cypress tests passing locally

[leanneeliatra]

This can now be reviewed please
The cypress workflow check Snapshot based E2E Cypress tests workflow / Run Cypress E2E tests (pull_request)
doesn't seem to be passing but as you can see above they are, so I am a bit confused there, can anyone direct please?
@Hailong-am @xluo-aws @SuZhou-Joe @ruanyl

[SuZhou-Joe]

This can now be reviewed please The cypress workflow check Snapshot based E2E Cypress tests workflow / Run Cypress E2E tests (pull_request) doesn't seem to be passing but as you can see above they are, so I am a bit confused there, can anyone direct please? @Hailong-am @xluo-aws @SuZhou-Joe @ruanyl

For the snapshot based test, it should has something to do with the Node version upgrade to v18 and you can ignore that for now.

Some action items maybe:

• For the file location, I suppose it should be located in cypress/integration/core-opensearch-dashboards instead of security-dashboards as it is a common issue in old version of OuiCopy. @leanneeliatra Could you help confirm that?
• For now FTRepo only runs integration tests in Chrome / Firefox without Safari, I suppose we may need to setup flow in Safari browser @ruanyl @kavilla I'd like to hear your advice about this.
• I am a little bit confused why the flow Security Release tests workflow in Bundled OpenSearch Dashboards was unable to run even though there are some changes matching its filter configuration, set up a issue to track.

[leanneeliatra]

Thank you @SuZhou-Joe for the feedback, much appreciated.

1. Yes the file location suggested seems like a better place for the new test, I have added it to that location and changed the name to be more descriptive.
   cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_share_copy_link_test.js
2. It would be great to get guidance on this. I have tested in Safari and the copy link works as expected but further guidance on whether we need to do something with the test for merging into the CI would be great. @ruanyl @kavilla
3. Thanks for opening the ticket with regard to Security Release tests workflow in Bundled OpenSearch Dashboards

[leanneeliatra]

This can now be reviewed please if anyone has a moment. Thanks.
cc @Hailong-am @xluo-aws @ruanyl

[Hailong-am]

waiting for opensearch-project/security-dashboards-plugin#1633 be merged

[leanneeliatra]

These can now be merged @Hailong-am, thank you for your assistance.