-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release 3.0] Adding 3.0.0-alpha1 in manifests and Jenkins runs #5251
[Release 3.0] Adding 3.0.0-alpha1 in manifests and Jenkins runs #5251
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
I will fix the test soon. |
Instead of fixing the test I will restore the 3.0.0 folder we are fine to add a 3.0.0-alpha1 instead of renaming. |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Could you look into the CI failure? Seems like manifest ci check is failing with qualifier. |
The issue is not on core as core just merged the lucene 10 changes in opensearch-project/OpenSearch#16366, which passed mavenlocal. The issue is on any plugin following as they havent start support the breaking changes in core yet on main. This means we would need to merge this PR and ignore the manifest check failures on 3.0.0-alpha1, so that we can start building min and bundle for plugin teams to pass their checks. Since we have continue-on-error already I am ok for us to merge this without removing the plugins. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manifest CI fails because of the recent breaking change. I don't think this should be a blocker for OS core.
Start to build on min should be a good step so far. I'm ok with this PR. Thanks.
Will merge tomorrow and build 3.0.0-alpha1. Thanks. |
…o 3.0.0-alpha1-bump
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Re-generate 3.0.0-alpha1 based on 2.19.0 to have all the exact same components and settings. Add a warning file in 3.0.0 manifest folder as we should not touch it until GA. Thanks. |
Description
[Release 3.0] Adding 3.0.0-alpha1 in manifests and Jenkins runs
Issues Resolved
#3747
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.