Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 3.0] Adding 3.0.0-alpha1 in manifests and Jenkins runs #5251

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jan 23, 2025

Description

[Release 3.0] Adding 3.0.0-alpha1 in manifests and Jenkins runs

Issues Resolved

#3747

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

I will fix the test soon.

@peterzhuamazon
Copy link
Member Author

Instead of fixing the test I will restore the 3.0.0 folder we are fine to add a 3.0.0-alpha1 instead of renaming.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon changed the title Update 3.0.0 to 3.0.0-alpha1 in manifests and Jenkins runs Adding 3.0.0-alpha1 in manifests and Jenkins runs Jan 23, 2025
@zelinh
Copy link
Member

zelinh commented Jan 23, 2025

Could you look into the CI failure? Seems like manifest ci check is failing with qualifier.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Jan 23, 2025

Could you look into the CI failure? Seems like manifest ci check is failing with qualifier.


2025-01-23 00:57:45 INFO     Executing "./gradlew publishToMavenLocal -Dopensearch.version=3.0.0-alpha1-SNAPSHOT -Dbuild.snapshot=true -Dbuild.version_qualifier=alpha1" in /tmp/tmptiar_71o/common-utils
Downloading https://services.gradle.org/distributions/gradle-8.10.2-bin.zip
.............10%.............20%.............30%.............40%.............50%.............60%.............70%.............80%.............90%.............100%

Welcome to Gradle 8.10.2!

Here are the highlights of this release:
 - Support for Java 23
 - Faster configuration cache
 - Better configuration cache reports

For more details see https://docs.gradle.org/8.10.2/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* Where:
Build file '/tmp/tmptiar_71o/common-utils/build.gradle' line: 156

* What went wrong:
A problem occurred evaluating root project 'common-utils'.
> Could not find method shadowJar() for arguments [build_auab109pypb5ye49zkgd5auvx$_run_closure11@69772b32] on root project 'common-utils' of type org.gradle.api.Project.

The issue is not on core as core just merged the lucene 10 changes in opensearch-project/OpenSearch#16366, which passed mavenlocal. The issue is on any plugin following as they havent start support the breaking changes in core yet on main.

This means we would need to merge this PR and ignore the manifest check failures on 3.0.0-alpha1, so that we can start building min and bundle for plugin teams to pass their checks.

Since we have continue-on-error already I am ok for us to merge this without removing the plugins. Thanks.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manifest CI fails because of the recent breaking change. I don't think this should be a blocker for OS core.
Start to build on min should be a good step so far. I'm ok with this PR. Thanks.

@peterzhuamazon
Copy link
Member Author

Will merge tomorrow and build 3.0.0-alpha1.

Thanks.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Re-generate 3.0.0-alpha1 based on 2.19.0 to have all the exact same components and settings.

Add a warning file in 3.0.0 manifest folder as we should not touch it until GA.

Thanks.

@peterzhuamazon peterzhuamazon merged commit 983a7f4 into opensearch-project:main Jan 23, 2025
17 checks passed
@peterzhuamazon peterzhuamazon deleted the 3.0.0-alpha1-bump branch January 23, 2025 19:45
@peterzhuamazon peterzhuamazon changed the title Adding 3.0.0-alpha1 in manifests and Jenkins runs [Release 3.0] Adding 3.0.0-alpha1 in manifests and Jenkins runs Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants