Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Apache Lucene 10 for 3.0.0 #16366

Merged
merged 117 commits into from
Jan 22, 2025
Merged

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 17, 2024

Description

Update to Apache Lucene 10 for 3.0.0

Related Issues

Closes #11415

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0 labels Oct 17, 2024
@reta
Copy link
Collaborator Author

reta commented Oct 17, 2024

@msfroh @mch2 @dblock @andrross opening the early draft pull request for collective effort, please feel free to push changes into this branch.

Copy link
Contributor

❌ Gradle check result for 76a5268: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 41d7448: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for df71508: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 77dcc97: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 19a8ca4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2b75ea1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 44df041: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 365a624: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ceb2b99: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 1, 2024

❌ Gradle check result for 61f4a3a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 1, 2024

❌ Gradle check result for e6c7f59: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 1, 2024

❌ Gradle check result for 0cfa7c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta requested a review from cwperks as a code owner January 21, 2025 13:19
Copy link
Contributor

❌ Gradle check result for 72496b0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 72496b0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta
Copy link
Collaborator Author

reta commented Jan 22, 2025

@andrross ready to go? I think we set it for today ...

@peterzhuamazon
Copy link
Member

@andrross ready to go? I think we set it for today ...

Hi @reta @andrross should we update buildSrc/version.properties with 3.0.0-alpha?

Thanks.

@reta
Copy link
Collaborator Author

reta commented Jan 22, 2025

Hi @reta @andrross should we update buildSrc/version.properties with 3.0.0-alpha?

I think this is the consensus most lean towards, I think you could go ahead and merge your pull request (#17020), I will update this branch right after (still have conflicts to resolve), thanks @peterzhuamazon !

@peterzhuamazon
Copy link
Member

Hi @reta @andrross should we update buildSrc/version.properties with 3.0.0-alpha?

I think this is the consensus most lean towards, I think you could go ahead and merge your pull request (#17020), I will update this branch right after (still have conflicts to resolve), thanks @peterzhuamazon !

This is merged:

Thanks.

Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work on this @reta! Let's rebase and get it merged today :)

@reta
Copy link
Collaborator Author

reta commented Jan 22, 2025

Thanks for all the hard work on this @reta! Let's rebase and get it merged today :)

Thanks to you (@andrross ), @msfroh , @expani and everyone who contributed!

Copy link
Contributor

❌ Gradle check result for 4c0b91e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 4c0b91e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link
Contributor

❕ Gradle check result for e5516fc: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta
Copy link
Collaborator Author

reta commented Jan 22, 2025

Let's make it rain! 🥳 🥳 🥳

@reta reta merged commit 7c46f8f into opensearch-project:main Jan 22, 2025
30 checks passed
@dhrubo-os
Copy link

dhrubo-os commented Jan 22, 2025

I could be wrong, but I think this PR is breaking the plugin workflow, example: https://github.com/opensearch-project/ml-commons/actions/runs/12918303491/job/36026598325?pr=3419

@reta
Copy link
Collaborator Author

reta commented Jan 22, 2025

I could be wrong, but I think this PR is breaking the plugin workflow, example: https://github.com/opensearch-project/ml-commons/actions/runs/12918303491/job/36026598325?pr=3419

@dhrubo-os it is inevitable sadly (although I am wondering why since we should not be updating the 3.0.0-SHAPSHOT but 3.0.0-alpha-SHAPSHOT)

@rbhavna
Copy link

rbhavna commented Jan 23, 2025

@reta is there a plan to fix these breaking changes from core? Or should we fixing them in our plugin? We have open PRs that need to go into 2.19

@reta
Copy link
Collaborator Author

reta commented Jan 23, 2025

@reta is there a plan to fix these breaking changes from core? Or should we fixing them in our plugin? We have open PRs that need to go into 2.19

@rbhavna yes, there is a pull request #17094 to update version (and republish snapshots right after)

@peterzhuamazon
Copy link
Member

3.0.0-SNAPSHOT has been roll back to lucene9 version with 3.0.0-before-alpha1 branch.
With #17094 lucene10 will be pushed to 3.0.0-alpha1-SNAPSHOT on sonatype.

@dhrubo-os @rbhavna

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update to Apache Lucene 10 for 3.0.0
10 participants