Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better filter display and behavior #17

Closed
joshuali925 opened this issue May 13, 2021 · 1 comment
Closed

Better filter display and behavior #17

joshuali925 opened this issue May 13, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@joshuali925
Copy link
Member

joshuali925 commented May 13, 2021

from opendistro-for-elasticsearch/trace-analytics#15:

Right now the filtering is directly based on on the field names in the index. Can this be made user friendly, example durationInNanos is not user friendly. If this can be changed as latency (in ms) and the at the query layer convert to nanos and apply it in filter.

Also, the filter only supports is, in between and not in between, equal to operation can we support less than, greater than instead?
Screen Shot 2021-01-29 at 3 17 20 PM


from opendistro-for-elasticsearch/trace-analytics#16:

Screen Shot 2021-01-29 at 3 21 45 PM

I applied a filter by duration, shouldn't the latency variance change based on the filter?

@joshuali925
Copy link
Member Author

This was addressed by opendistro-for-elasticsearch/trace-analytics#28, the label is now latency which is in milliseconds

joshuali925 pushed a commit to joshuali925/observability that referenced this issue Sep 8, 2021
Signed-off-by: David Cui <davidcui@amazon.com>
joshuali925 pushed a commit to joshuali925/observability that referenced this issue Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant