This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Allow filtering by traceGroup and service #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
approved these changes
Mar 26, 2021
joshuali925
added a commit
that referenced
this pull request
Mar 29, 2021
zhongnansu
pushed a commit
that referenced
this pull request
Apr 6, 2021
* Move service map to dashboard * Add back filters * Remove services table search bar * Add service map filter * Fix percentile * Make unrelated services transparent * Update jest tests * Fix trace count in dashboard * Fix ticks * Fix parent span query * Fix trace group filters for service map * Revert plot query filters * Use trace count in histogram * Use trace count in error rate histogram * Rename plots * services view respecting filters * Add special case for latency and errors filter * Fix service map color calculation * Fix error rate plot query * Rename traceGroup field to traceGroup.name * Update dashboard queries to calculate on parent span level * Update filter fields to use parent span latency and errors * Update traces queries to calculate on parent span level * Update jest * Fix percentile filter DSL * UX changes * Fix service map query targetResource to use traceGroup.name * Update jest tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#27
Description of changes:
traceGroup.nameandserviceNameon dashboard and services pageBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.