Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to main] check state before deleting model or task (#725) #783

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Backport PR #725 to main branch

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn requested a review from a team March 4, 2023 00:45
rbhavna
rbhavna previously approved these changes Mar 4, 2023
b4sjoo
b4sjoo previously approved these changes Mar 4, 2023
rbhavna and others added 2 commits March 3, 2023 16:50
Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn dismissed stale reviews from b4sjoo and rbhavna via 79232ba March 4, 2023 00:50
@codecov-commenter
Copy link

Codecov Report

Merging #783 (9322d33) into main (c738cc4) will decrease coverage by 0.03%.
The diff coverage is 81.13%.

❗ Current head 9322d33 differs from pull request most recent head 79232ba. Consider uploading reports for the commit 79232ba to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #783      +/-   ##
============================================
- Coverage     84.40%   84.38%   -0.03%     
- Complexity     1587     1595       +8     
============================================
  Files           135      135              
  Lines          5901     5937      +36     
  Branches        556      560       +4     
============================================
+ Hits           4981     5010      +29     
- Misses          685      690       +5     
- Partials        235      237       +2     
Flag Coverage Δ
ml-commons 84.38% <81.13%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...h/ml/action/models/DeleteModelTransportAction.java 89.06% <78.57%> (-1.85%) ⬇️
...rch/ml/action/tasks/DeleteTaskTransportAction.java 88.88% <84.00%> (-11.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ylwu-amzn ylwu-amzn changed the title [Backport to main] check state before deleting model or task [Backport to main] check state before deleting model or task (#725) Mar 4, 2023
@ylwu-amzn ylwu-amzn merged commit a27b0ed into opensearch-project:main Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants