check state before deleting model or task #725
Conversation
Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com>
There was a problem hiding this comment.
LGTM. But to be on the safe side, are you still planning to check the model and task status in the cache memory to make sure they are not deleted? You can add it in a separate PR. https://github.com/opensearch-project/ml-commons/blob/main/plugin/src/main/java/org/opensearch/ml/model/MLModelCache.java, and, https://github.com/opensearch-project/ml-commons/blob/main/plugin/src/main/java/org/opensearch/ml/task/MLTaskCache.java.
Yes, I think we might have to do it. |
| } | ||
| }); | ||
| }, e -> { actionListener.onFailure(new MLResourceNotFoundException("Fail to find model")); }), () -> context.restore())); |
There was a problem hiding this comment.
From line 81, we are going to restore context before running listener to delete model. Will it fail on security enabled cluster?
There was a problem hiding this comment.
Tested it on security enabled cluster and it works. Adding test results here.
Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com>
Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com>
Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com>
…783) * check state before deleting model or task (#725) Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix breaking change Signed-off-by: Yaliang Wu <ylwu@amazon.com> --------- Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com>
Signed-off-by: Bhavana Goud Ramaram rbhavna@amazon.com
Description
This PR check the condition for model state before deleting a model. If the model is in loaded/loading/partially loaded state, it throws exception and tells user to unload the model first. Previously, the delete API would delete the model irrespective of any model state which was no desirable.
Also checks condition for task state before deleting a task. If task is in running state, it throws an exception.
Issues Resolved
#665
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.