- 
                Notifications
    You must be signed in to change notification settings 
- Fork 184
Update interaction with failure message on agent execution failure #4198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update interaction with failure message on agent execution failure #4198
Conversation
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@             Coverage Diff              @@
##               main    #4198      +/-   ##
============================================
+ Coverage     81.69%   81.74%   +0.04%     
- Complexity     9374     9384      +10     
============================================
  Files           796      796              
  Lines         40622    40652      +30     
  Branches       4515     4519       +4     
============================================
+ Hits          33186    33230      +44     
+ Misses         5490     5471      -19     
- Partials       1946     1951       +5     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| CI failure is unrelated & flaky  | 
| Rebase with main branch ? | 
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
88b554c    to
    5b8aa24      
    Compare
  
    | 
 Rebased! | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, but we just do a general error message now. later when we know the pattern of the errors. we better to do different error handling for different types of failures (validation, execution, timeout). That would be better for user to understand rather than throwing the raw exception message.
| Thanks @mingshl Agreed! Another improvement I notice: 
 This PR is a start towards that as the error message handling is happening in a common place. | 
Description
When an agent runs, it creates a new interaction. On successful execution, this interaction is updated with the final response. However, on agent failures, the interaction never gets updated. Therefore, this PR addresses that gap.
Example:
Before in case of agent failures, response field is never populated
After
Related Issues
Resolves #4197
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.