-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add memory id and interation id for non-verbose #2004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jing Zhang <jngz@amazon.com>
jngz-es
requested review from
b4sjoo,
dhrubo-os,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
February 3, 2024 07:40
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 3, 2024 07:40 — with
GitHub Actions
Failure
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 3, 2024 07:40 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 3, 2024 07:40 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 3, 2024 07:40 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 3, 2024 07:40 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 3, 2024 07:40 — with
GitHub Actions
Inactive
b4sjoo
approved these changes
Feb 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2004 +/- ##
============================================
+ Coverage 82.55% 82.56% +0.01%
+ Complexity 5577 5576 -1
============================================
Files 540 540
Lines 22431 22453 +22
Branches 2286 2286
============================================
+ Hits 18517 18538 +21
- Misses 2981 2984 +3
+ Partials 933 931 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 3, 2024 08:07 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 3, 2024 08:07 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 3, 2024 08:07 — with
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Feb 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2024
Signed-off-by: Jing Zhang <jngz@amazon.com> (cherry picked from commit b84b130)
ylwu-amzn
pushed a commit
that referenced
this pull request
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add memory id and parent interaction id in response.
An example,
Issues Resolved
#1988
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.