Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] memory id and interaction id is not return when verbose is false #1988

Closed
SuZhou-Joe opened this issue Feb 2, 2024 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request untriaged

Comments

@SuZhou-Joe
Copy link
Member

SuZhou-Joe commented Feb 2, 2024

Is your feature request related to a problem?
memory id and interaction id are two fields that can be used for retrieving related informations in memory layer, so they should not be hidden when verbose is set to false.

What solution would you like?
Return memory id and interaction id in _execute API no matter verbose is true or false.

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@xluo-aws
Copy link
Member

xluo-aws commented Feb 3, 2024

@SuZhou-Joe , what if they are not returned? Suggestions, regeneration and how to generate will not work, right?

@SuZhou-Joe
Copy link
Member Author

@SuZhou-Joe , what if they are not returned? Suggestions, regeneration and how to generate will not work, right?

Correct, those won't work.

@dhrubo-os
Copy link
Collaborator

Closing this issue in favor of: #2004

@github-project-automation github-project-automation bot moved this from In Progress to Done in ml-commons projects Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
Development

No branches or pull requests

4 participants