Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update model status labels according to the API change in 2.7 #154

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Mar 28, 2023

This PR updates the model status labels according to the ml-commons breaking changes introduced in 2.7: opensearch-project/ml-commons#822

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl ruanyl requested review from wanglam, raintygao and a team March 28, 2023 07:47
@ruanyl ruanyl assigned ruanyl and unassigned ruanyl Mar 28, 2023
Copy link

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just make sure replace the old model states for all places

@ruanyl ruanyl merged commit 7628ee2 into opensearch-project:main Apr 3, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 3, 2023
)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit 7628ee2)
wanglam pushed a commit to wanglam/ml-commons-dashboards that referenced this pull request Apr 27, 2023
wanglam pushed a commit to wanglam/ml-commons-dashboards that referenced this pull request Apr 28, 2023
wanglam pushed a commit to wanglam/ml-commons-dashboards that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants