-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename API/function/variable names #822
Conversation
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@@ -29,22 +29,22 @@ | |||
@ToString | |||
public class MLUploadModelChunkRequest extends ActionRequest { | |||
|
|||
MLUploadModelChunkInput mlUploadInput; | |||
MLUploadModelChunkInput uploadModelChunkInput; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are using register for full model model, why not use register model chunk here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We change to register mainly for extending the API scope to support pre-trained model on model repo and virtual remote models. This upload model chunk API doesn't need to extend its scope. But I will reconfirm with UX/PM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest go ahead and review other parts. We can create a new PR for the model chunk APIs if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still waiting for more comments from UX/PM. Will merge this PR for now. May cut a new PR when get finalized decision.
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #822 +/- ##
============================================
- Coverage 84.90% 84.74% -0.16%
+ Complexity 1626 1622 -4
============================================
Files 135 135
Lines 6036 6059 +23
Branches 589 592 +3
============================================
+ Hits 5125 5135 +10
- Misses 659 668 +9
- Partials 252 256 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
* rename API/function/variable names Signed-off-by: Yaliang Wu <ylwu@amazon.com> * remove deprecated fields from model index Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix some variable name Signed-off-by: Yaliang Wu <ylwu@amazon.com> --------- Signed-off-by: Yaliang Wu <ylwu@amazon.com>
* rename API/function/variable names Signed-off-by: Yaliang Wu <ylwu@amazon.com> * remove deprecated fields from model index Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix some variable name Signed-off-by: Yaliang Wu <ylwu@amazon.com> --------- Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Description
Rename APIs
With these changes, we also changed other places
LOADED
->DEPLOYED
uploadModel
->deployModel
uploadInput
->registerModelInput
Issues Resolved
#823
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.