-
Couldn't load subscription status.
- Fork 130
update to gradle 8.1.1 in 2.x branch #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #777 +/- ##
============================================
+ Coverage 74.82% 75.88% +1.06%
Complexity 2647 2647
============================================
Files 337 337
Lines 15560 15552 -8
Branches 2402 2252 -150
============================================
+ Hits 11642 11801 +159
+ Misses 2538 2437 -101
+ Partials 1380 1314 -66 |
|
Thanks for the change! |
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Just uploaded my commit to upgrade gradle wrapper and corrected typo in my commit message. Meanwhile, I think the multi node test workflow is a flaky test, which may sometimes produce unexpected error. I will include the error log in your issue about flaky test later. You can take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, and maybe can also include Fix flaky test test history shard settings into this PR. @bowenlan-amzn could you confirm this is right change for fix flaky test?
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Just included this change, please take a look, thanks! |
|
Yes, looks good. Thanks! |
* upgrade to gradle 8.1.1 Signed-off-by: yuye-aws <yuyezhu@amazon.com> * upgrade gradle wrapper Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Fix flaky test: test history shard settings Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Issue #, if available:
Description of changes:
test history shard settingsCheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.