Skip to content

Conversation

@yuye-aws
Copy link
Member

@yuye-aws yuye-aws commented May 11, 2023

Issue #, if available:

Description of changes:

  • Fix build failures by upgrading to gradle 8.1.1
  • Change nebula.ospackage to com.netflix.nebula.ospackage gradle scripts
  • Fix flaky test test history shard settings

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@yuye-aws yuye-aws mentioned this pull request May 11, 2023
1 task
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #777 (40e4a4f) into 2.x (2006631) will increase coverage by 1.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #777      +/-   ##
============================================
+ Coverage     74.82%   75.88%   +1.06%     
  Complexity     2647     2647              
============================================
  Files           337      337              
  Lines         15560    15552       -8     
  Branches       2402     2252     -150     
============================================
+ Hits          11642    11801     +159     
+ Misses         2538     2437     -101     
+ Partials       1380     1314      -66     

see 65 files with indirect coverage changes

@bowenlan-amzn
Copy link
Member

Thanks for the change!
Can you run gradle wrapper --gradle-version 8.1.1 to upgrade all the gradle related stuff in the project also

@bowenlan-amzn bowenlan-amzn self-requested a review May 11, 2023 16:16
@yuye-aws yuye-aws changed the title upgradle to gradle 8.1.1 upgrade to gradle 8.1.1 May 12, 2023
@yuye-aws yuye-aws changed the title upgrade to gradle 8.1.1 update to gradle 8.1.1 in 2.x branch May 12, 2023
yuye-aws added 2 commits May 12, 2023 09:28
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
@yuye-aws
Copy link
Member Author

yuye-aws commented May 12, 2023

Thanks for the change! Can you run gradle wrapper --gradle-version 8.1.1 to upgrade all the gradle related stuff in the project also

Just uploaded my commit to upgrade gradle wrapper and corrected typo in my commit message. Meanwhile, I think the multi node test workflow is a flaky test, which may sometimes produce unexpected error. I will include the error log in your issue about flaky test later. You can take a look.

Hailong-am
Hailong-am previously approved these changes May 12, 2023
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, and maybe can also include Fix flaky test test history shard settings into this PR. @bowenlan-amzn could you confirm this is right change for fix flaky test?

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
@yuye-aws
Copy link
Member Author

looks good to me, and maybe can also include Fix flaky test test history shard settings into this PR. @bowenlan-amzn could you confirm this is right change for fix flaky test?

Just included this change, please take a look, thanks!

@bowenlan-amzn
Copy link
Member

Yes, looks good. Thanks!

@bowenlan-amzn bowenlan-amzn merged commit 86339f9 into opensearch-project:2.x May 12, 2023
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
* upgrade to gradle 8.1.1

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* upgrade gradle wrapper

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Fix flaky test: test history shard settings

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants