Skip to content

Conversation

@bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented May 6, 2023

Issue #, if available:

Description of changes:

  • Use com.netflix.nebula.ospackage now to be in consistent with core
  • Remove 2 migration services (template, metadata), since breaking change is acceptable for 3.0, user should first upgrade to 2.x before upgrading to 3.0, these migration services are not useful anymore.
  • Fix deprecations
  • Fix flaky test test history shard settings

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bowenlan-amzn bowenlan-amzn force-pushed the main branch 2 times, most recently from 4ff0bd6 to 2be28eb Compare May 6, 2023 05:39
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Merging #771 (354d20c) into main (76272ee) will increase coverage by 0.11%.
The diff coverage is 36.36%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #771      +/-   ##
============================================
+ Coverage     75.35%   75.47%   +0.11%     
+ Complexity     2673     2588      -85     
============================================
  Files           337      335       -2     
  Lines         15562    15174     -388     
  Branches       2286     2189      -97     
============================================
- Hits          11727    11452     -275     
+ Misses         2496     2447      -49     
+ Partials       1339     1275      -64     
Impacted Files Coverage Δ
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 70.42% <ø> (+0.19%) ⬆️
...atemanagement/step/shrink/AttemptMoveShardsStep.kt 57.70% <0.00%> (ø)
...atemanagement/step/shrink/WaitForMoveShardsStep.kt 45.45% <0.00%> (-3.78%) ⬇️
...exstatemanagement/step/shrink/WaitForShrinkStep.kt 40.00% <0.00%> (-2.00%) ⬇️
...adata/TransportUpdateManagedIndexMetaDataAction.kt 75.86% <ø> (-10.35%) ⬇️
...tion/mapping/TransportUpdateRollupMappingAction.kt 65.00% <ø> (ø)
.../rollup/util/RollupFieldValueExpressionResolver.kt 61.53% <0.00%> (ø)
.../org/opensearch/indexmanagement/util/IndexUtils.kt 76.41% <0.00%> (+0.94%) ⬆️
...arch/indexmanagement/rollup/RollupMapperService.kt 58.58% <50.00%> (ø)
...ndexstatemanagement/IndexStateManagementHistory.kt 78.08% <66.66%> (+0.84%) ⬆️
... and 4 more

... and 30 files with indirect coverage changes

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review May 6, 2023 06:17
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
@getsaurabh02 getsaurabh02 merged commit 7c25829 into opensearch-project:main May 8, 2023
@yuye-aws
Copy link
Member

yuye-aws commented May 11, 2023

I have submitted another pull request to fix the similar build failure problem on 2.x branch. Two reviewers are required to approve my pull request but there is no code reviewer assigned yet. Could you help review my code? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants