Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremented version to 1.3.4. #407

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Jul 7, 2022

Signed-off-by: Zelin Hao zelinhao@amazon.com

Issue #, if available:
Part of opensearch-project/opensearch-build#2205
Description of changes:
Increment version to 1.3.4
CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh zelinh requested a review from a team July 7, 2022 21:44
@downsrob
Copy link
Contributor

Blocked: Could not find org.opensearch:notification:1.3.4.0-SNAPSHOT
Need this PR to get merged first opensearch-project/alerting#488

@zelinh
Copy link
Member Author

zelinh commented Jul 11, 2022

Blocked: Could not find org.opensearch:notification:1.3.4.0-SNAPSHOT Need this PR to get merged first opensearch-project/alerting#488

@downsrob Why this asks for notification plugins? Isn't notification introduced until 2.0.0 release?

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@downsrob
Copy link
Contributor

@zelinh You can see the previous version snapshots here https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/notification/
Notification did exist, but it was a sub-plugin under alerting https://github.com/opensearch-project/alerting/tree/1.3/notification/src
It didn't have all of the same functionality as the notification successor which was released in 2.0, but provided the basic functionality of publishing a notification to a destination

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #407 (4200319) into 1.3 (dae81c5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.3     #407   +/-   ##
=========================================
  Coverage     75.66%   75.67%           
- Complexity     2009     2012    +3     
=========================================
  Files           253      253           
  Lines         11489    11489           
  Branches       1819     1819           
=========================================
+ Hits           8693     8694    +1     
+ Misses         1765     1763    -2     
- Partials       1031     1032    +1     
Impacted Files Coverage Δ
...arch/indexmanagement/rollup/RollupSearchService.kt 59.25% <0.00%> (-5.56%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 83.96% <0.00%> (-0.48%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 66.46% <0.00%> (ø)
...xmanagement/rollup/actionfilter/FieldCapsFilter.kt 74.11% <0.00%> (+1.17%) ⬆️
...management/indexstatemanagement/MetadataService.kt 64.06% <0.00%> (+2.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae81c5...4200319. Read the comment docs.

@bowenlan-amzn bowenlan-amzn merged commit 59e8816 into opensearch-project:1.3 Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants