Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.3.5] Version increment and add build.sh #470

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

prudhvigodithi
Copy link
Contributor

@prudhvigodithi prudhvigodithi commented Aug 16, 2022

Issue #, if available:

Description of changes:
Incremented version to 1.3.5.
Part of: opensearch-project/opensearch-build#2348

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
@dblock
Copy link
Member

dblock commented Aug 17, 2022

CI needs to pass.

@prudhvigodithi prudhvigodithi changed the title [Release 1.3.5] Version increment [Release 1.3.5] Version increment and add build.sh Aug 17, 2022
@prudhvigodithi
Copy link
Contributor Author

prudhvigodithi commented Aug 17, 2022

Hey @downsrob @praveensameneni can you please review this PR and check with the tests?
I see its dependent on notifications but notifications are from 2.x.

@dblock
Copy link
Member

dblock commented Aug 17, 2022

@prudhvigodithi There are more files to increment the version in, see #407 for an example.

@prudhvigodithi
Copy link
Contributor Author

prudhvigodithi commented Aug 17, 2022

Right @dblock but that was before this issue was fixed #402, now AFAIK we dont need to update the workflows.
@downsrob

@dblock
Copy link
Member

dblock commented Aug 17, 2022

In 1.x notification comes from alerting -> opensearch-project/opensearch-build#2474

@codecov-commenter
Copy link

Codecov Report

Merging #470 (d68858d) into 1.3 (f8113ce) will increase coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #470      +/-   ##
============================================
+ Coverage     75.16%   75.52%   +0.35%     
+ Complexity     1997     1994       -3     
============================================
  Files           253      253              
  Lines         11475    11475              
  Branches       1816     1816              
============================================
+ Hits           8625     8666      +41     
+ Misses         1840     1775      -65     
- Partials       1010     1034      +24     
Impacted Files Coverage Δ
...ndexmanagement/transform/model/ExplainTransform.kt 53.84% <0.00%> (-23.08%) ⬇️
...nt/indexstatemanagement/model/destination/Chime.kt 40.90% <0.00%> (-13.64%) ⬇️
...nt/indexstatemanagement/model/destination/Slack.kt 40.90% <0.00%> (-13.64%) ⬇️
...dexmanagement/transform/model/TransformMetadata.kt 82.17% <0.00%> (-8.92%) ⬇️
...ansform/action/explain/ExplainTransformResponse.kt 77.77% <0.00%> (-7.41%) ⬇️
...arch/indexmanagement/rollup/RollupSearchService.kt 61.11% <0.00%> (-3.71%) ⬇️
.../action/explain/TransportExplainTransformAction.kt 67.04% <0.00%> (-2.28%) ⬇️
...management/indexstatemanagement/MetadataService.kt 60.93% <0.00%> (-0.79%) ⬇️
...earch/indexmanagement/transform/model/Transform.kt 85.21% <0.00%> (-0.44%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 65.97% <0.00%> (-0.30%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bowenlan-amzn bowenlan-amzn merged commit b47bcb1 into opensearch-project:1.3 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants