Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] PR with no license headers didn't fail checks #34

Closed
adityaj1107 opened this issue Jun 3, 2021 · 1 comment
Closed

[BUG] PR with no license headers didn't fail checks #34

adityaj1107 opened this issue Jun 3, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@adityaj1107
Copy link
Contributor

Issue by dbbaughe
Wednesday Feb 05, 2020 at 21:47 GMT
Originally opened as opendistro-for-elasticsearch/index-management#144

Describe the bug
This PR had some files with missing license headers. It should fail an automatic check instead of relying on human verification.

Expected behavior
Run ./gradlew build with a source file w/ no License Header and fail.
@adityaj1107 adityaj1107 added the bug Something isn't working label Jun 3, 2021
@adityaj1107
Copy link
Contributor Author

Comment by dbbaughe
Friday Apr 03, 2020 at 19:32 GMT

Skips when there are no java files which is why task isn't running
https://github.com/elastic/elasticsearch/blob/master/buildSrc/src/main/groovy/org/elasticsearch/gradle/precommit/LicenseHeadersTask.groovy#L71

@bowenlan-amzn bowenlan-amzn mentioned this issue Sep 9, 2021
Merged
1 task
thalurur pushed a commit to thalurur/open-index-management that referenced this issue Oct 22, 2021
@annie3431
Documentation url update (opensearch-project#34)
e9eae5c 
Update documentation url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adityaj1107 @bowenlan-amzn