Fix capitilzation of default engine example #8624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
requested review from
AMoo-Miki,
dlvenable,
epugh,
kolchfa-aws,
natebower and
vagimeli
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
This PR does not need to be backported since it is related to a 2.18 change, #8620 |
VijayanB
reviewed
Oct 28, 2024
_search-plugins/knn/knn-index.md
Outdated
| `name` | true | n/a | false | The identifier for the nearest neighbor method. | ||
| `space_type` | false | l2 | false | The vector space used to calculate the distance between vectors. Note: This value can also be specified at the top level of the mapping. | ||
| `engine` | false | Faiss | false | The approximate k-NN library to use for indexing and search. The available libraries are Faiss, nmslib, and Lucene. | ||
| `engine` | false | faiss | false | The approximate k-NN library to use for indexing and search. The available libraries are Faiss, nmslib, and Lucene. |
There was a problem hiding this comment.
Suggested change
| `engine` | false | faiss | false | The approximate k-NN library to use for indexing and search. The available libraries are Faiss, nmslib, and Lucene. | |
| `engine` | false | faiss | false | The approximate k-NN library to use for indexing and search. The available libraries are faiss, nmslib, and lucene. |
There was a problem hiding this comment.
shall we make this change as well?
Naarcha-AWS
commented
Oct 28, 2024
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
VijayanB
approved these changes
Oct 28, 2024
|
Can this be merged? |
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Nov 23, 2024
* Fix capitilzation of default engine example Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Jul 2, 2025
* Fix capitilzation of default engine example Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the capitalization of new default for
enginesetting, according to developer feedback.Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.