Update default engine from nmslib to faiss #8620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting 2.18, default knn engine is faiss. Updating the documentation accordingly Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
requested review from
AMoo-Miki,
Naarcha-AWS,
dlvenable,
epugh,
kolchfa-aws,
natebower and
vagimeli
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@navneet1v @jmazanec15 are there any other place that needs an update in documentation? |
Naarcha-AWS
reviewed
Oct 25, 2024
Naarcha-AWS
reviewed
Oct 25, 2024
Naarcha-AWS
reviewed
Oct 25, 2024
Naarcha-AWS
reviewed
Oct 25, 2024
Naarcha-AWS
reviewed
Oct 25, 2024
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
added
Doc review
Naarcha-AWS
approved these changes
Oct 25, 2024
This was referenced Oct 28, 2024
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Jul 2, 2025
* Update default engine from nmslib to faiss Starting 2.18, default knn engine is faiss. Updating the documentation accordingly Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting 2.18, default knn engine is faiss. Updating the documentation accordingly
Issues Resolved
Closes #8589
Version
2.18 onwards
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.