-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi datasource support #311
Merged
sumukhswamy
merged 19 commits into
opensearch-project:main
from
sumukhswamy:multi-datasource
May 1, 2024
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1a98286
added mds changes
sumukhswamy a1e7567
added mds changes
sumukhswamy 596e1c5
added more changes
sumukhswamy aa0c837
upadted the group buttons and calls with mds
sumukhswamy 4150721
added changes for and cache management
sumukhswamy fad9c25
added changes for PPL page, changes for fetching queries
sumukhswamy 737c959
main test added
sumukhswamy 3896e60
added datsource dependency
sumukhswamy 3b5137d
updated the tests for workbench with snapshots
sumukhswamy 5a08ea2
Update common/utils/fetch_datasources.ts
sumukhswamy 75e01b3
Merge branch 'main' into multi-datasource
sumukhswamy 856bbab
updated lint checker in async workbench
sumukhswamy 8de3cce
updated with new comments
sumukhswamy d57d3ed
added UX changes
sumukhswamy 3521da7
added changed for pr comments
sumukhswamy 1a833d9
added changes for linter
sumukhswamy ad0897f
added changes for snapshop
sumukhswamy dc95c8c
added snapshot for main
sumukhswamy 0e09356
updated tests for main
sumukhswamy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
|
||
import { CoreStart } from "../../../../src/core/public"; | ||
|
||
export const fetchDataSources = (http: CoreStart['http'], dataSourceMDSId: string, urlDataSource: string, onSuccess, onError) => { | ||
let dataOptions: { label: string; options?: Array<{ label: string }>; }[] = []; | ||
let urlSourceFound = false; | ||
if(!dataSourceMDSId){ | ||
dataSourceMDSId = '' | ||
} | ||
|
||
http.get(`/api/get_datasources/${dataSourceMDSId}`) | ||
.then((res) => { | ||
const data = res.data.resp; | ||
const connectorGroups = {}; | ||
|
||
data.forEach((item) => { | ||
const { connector, name } = item | ||
|
||
if (connector === 'S3GLUE') { | ||
if (!connectorGroups[connector]) { | ||
connectorGroups[connector] = []; | ||
} | ||
|
||
connectorGroups[connector].push(name); | ||
if (name === urlDataSource) { | ||
urlSourceFound = true; | ||
} | ||
} | ||
}); | ||
sumukhswamy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
for (const connector in connectorGroups) { | ||
if (connectorGroups.hasOwnProperty(connector)) { | ||
const connectorNames = connectorGroups[connector]; | ||
|
||
dataOptions.push({ | ||
label: connector, | ||
options: connectorNames.map((name) => ({ label: name })), | ||
}); | ||
} | ||
} | ||
|
||
onSuccess(dataOptions, urlSourceFound); | ||
}) | ||
.catch((err) => { | ||
console.error(err); | ||
onError(err); | ||
}); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is urlDataSource? Can we give a better name?