-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi datasource support #311
Multi datasource support #311
Conversation
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
} | ||
|
||
connectorGroups[connector].push(name); | ||
if (name === urlDataSource) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is urlDataSource? Can we give a better name?
constructor(props: SwitchProps) { | ||
super(props); | ||
this.state = { | ||
cluster: 'Indexes', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we use this anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason I have a state here is to distinguish between indexes tab and data connections, which I check in
https://github.com/opensearch-project/dashboards-query-workbench/pull/311/files#diff-3ff08cae50890804a95e00ef9f0f2a560c5ef12a4075e322612f7008bcdaa978R23
Can we add test details with screenshots or recording? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't finish, will review later
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Sumukh Swamy <sumukhhs@amazon.com>
Screen.Recording.2024-04-25.at.4.50.21.PM.mov |
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
132f6b4
to
8de3cce
Compare
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
):( | ||
<EuiFlexItem grow={false}> | ||
<EuiEmptyPrompt | ||
icon={<EuiIcon type="database" size="m" />} | ||
iconColor="subdued" | ||
titleSize="xs" | ||
body={<p>Select a Data Source Connection to fetch Databases</p>} | ||
/> | ||
</EuiFlexItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested ternary operators are difficult to understand, maybe can be split in variables like done inside the tree code.
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@sumukhswamy Can you please create an issue for fast follow on the linter issues? We can fix these after this PR is merged. |
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-query-workbench/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-query-workbench/backport-2.x
# Create a new branch
git switch --create backport/backport-311-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bb6116d4110500f89c62c03a3472013c311b2be2
# Push it to GitHub
git push --set-upstream origin backport/backport-311-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-query-workbench/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-query-workbench/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/dashboards-query-workbench/backport-2.14
# Create a new branch
git switch --create backport/backport-311-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bb6116d4110500f89c62c03a3472013c311b2be2
# Push it to GitHub
git push --set-upstream origin backport/backport-311-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-query-workbench/backport-2.14 Then, create a pull request where the |
* added mds changes Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added mds changes Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added more changes Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * upadted the group buttons and calls with mds Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for and cache management Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for PPL page, changes for fetching queries Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * main test added Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added datsource dependency Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated the tests for workbench with snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Update common/utils/fetch_datasources.ts Co-authored-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Sumukh Swamy <sumukhhs@amazon.com> * updated lint checker in async workbench Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated with new comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added UX changes Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changed for pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for linter Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for snapshop Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added snapshot for main Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated tests for main Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Sumukh Swamy <sumukhhs@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com>
* added mds changes Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added mds changes Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added more changes Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * upadted the group buttons and calls with mds Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for and cache management Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for PPL page, changes for fetching queries Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * main test added Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added datsource dependency Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated the tests for workbench with snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Update common/utils/fetch_datasources.ts Co-authored-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Sumukh Swamy <sumukhhs@amazon.com> * updated lint checker in async workbench Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated with new comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added UX changes Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changed for pr comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for linter Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added changes for snapshop Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added snapshot for main Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated tests for main Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Sumukh Swamy <sumukhhs@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com>
* added mds changes * added mds changes * added more changes * upadted the group buttons and calls with mds * added changes for and cache management * added changes for PPL page, changes for fetching queries * main test added * added datsource dependency * updated the tests for workbench with snapshots * Update common/utils/fetch_datasources.ts * updated lint checker in async workbench * updated with new comments * added UX changes * added changed for pr comments * added changes for linter * added changes for snapshop * added snapshot for main * updated tests for main --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Sumukh Swamy <sumukhhs@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com>
* added mds changes * added mds changes * added more changes * upadted the group buttons and calls with mds * added changes for and cache management * added changes for PPL page, changes for fetching queries * main test added * added datsource dependency * updated the tests for workbench with snapshots * Update common/utils/fetch_datasources.ts * updated lint checker in async workbench * updated with new comments * added UX changes * added changed for pr comments * added changes for linter * added changes for snapshop * added snapshot for main * updated tests for main --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Sumukh Swamy <sumukhhs@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com>
Description
mds support for neo
cache changes
#303
Issues Resolved
#266
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.