[Backport main] move performance now to run time dep (#309) #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move performance now to run time dep Signed-off-by: Derek Ho <dxho@amazon.com> * update release notes for this PR and CI fix PR Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit c046499)
derek-ho
approved these changes
Feb 23, 2023
mengweieric
approved these changes
Feb 23, 2023
joshuali925
approved these changes
Feb 23, 2023
package.json
Outdated
| @@ -48,7 +49,7 @@ | |||
| "husky": "6.0.0", | |||
| "jest-dom": "^4.0.0", | |||
| "lint-staged": "^13.1.0", | |||
| "performance-now": "^2.1.0" | |||
| "jest-dom": "^4.0.0" | |||
There was a problem hiding this comment.
no code change for adding jest-dom?
There was a problem hiding this comment.
seems like 2 'jest-dom' exists
There was a problem hiding this comment.
@ps48 can you remove the extra dep? I just checked the original PR doesn't have this might have happened during merge
There was a problem hiding this comment.
The duplication arose due to auto-merge in cherry pick. Fixed it.
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
mengweieric
pushed a commit
that referenced
this pull request
Apr 3, 2023
* move performance now to run time dep (#309) * move performance now to run time dep Signed-off-by: Derek Ho <dxho@amazon.com> * update release notes for this PR and CI fix PR Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit c046499) * remove duplicate jest-dom Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated snapshots for notebooks Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com>
derek-ho
added a commit
to derek-ho/dashboards-observability
that referenced
this pull request
Apr 5, 2023
…ect#309) (opensearch-project#311) * move performance now to run time dep (opensearch-project#309) * move performance now to run time dep Signed-off-by: Derek Ho <dxho@amazon.com> * update release notes for this PR and CI fix PR Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit c046499) * remove duplicate jest-dom Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated snapshots for notebooks Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Ho dxho@amazon.com
Signed-off-by: Derek Ho dxho@amazon.com
Signed-off-by: Derek Ho dxho@amazon.com
(cherry picked from commit c046499)
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.