Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move performance now to run time dep #309

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Feb 23, 2023

Description

performance-now package was moved from dev-dependencies to dependencies

Issues Resolved

  • move performance now to run time dep

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho merged commit c046499 into opensearch-project:2.6 Feb 23, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-309-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0464990e3ba502d6def838edf14a0d7ef5bea92
# Push it to GitHub
git push --set-upstream origin backport/backport-309-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-309-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-309-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0464990e3ba502d6def838edf14a0d7ef5bea92
# Push it to GitHub
git push --set-upstream origin backport/backport-309-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-309-to-main.

derek-ho added a commit to derek-ho/dashboards-observability that referenced this pull request Feb 23, 2023
* move performance now to run time dep

Signed-off-by: Derek Ho <dxho@amazon.com>

* update release notes for this PR and CI fix PR

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit c046499)
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho added a commit to derek-ho/dashboards-observability that referenced this pull request Feb 23, 2023
* move performance now to run time dep

Signed-off-by: Derek Ho <dxho@amazon.com>

* update release notes for this PR and CI fix PR

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit c046499)
Signed-off-by: Derek Ho <dxho@amazon.com>
ps48 pushed a commit that referenced this pull request Feb 23, 2023
* move performance now to run time dep

Signed-off-by: Derek Ho <dxho@amazon.com>

* update release notes for this PR and CI fix PR

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit c046499)
derek-ho added a commit that referenced this pull request Feb 23, 2023
* move performance now to run time dep



* update release notes for this PR and CI fix PR



---------


(cherry picked from commit c046499)

Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho added a commit to derek-ho/dashboards-observability that referenced this pull request Feb 27, 2023
…arch-project#310)

* move performance now to run time dep



* update release notes for this PR and CI fix PR



---------


(cherry picked from commit c046499)

Signed-off-by: Derek Ho <dxho@amazon.com>
ps48 added a commit that referenced this pull request Mar 27, 2023
* move performance now to run time dep (#309)

* move performance now to run time dep

Signed-off-by: Derek Ho <dxho@amazon.com>

* update release notes for this PR and CI fix PR

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit c046499)

* remove duplicate jest-dom

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updated snapshots for notebooks

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
mengweieric pushed a commit that referenced this pull request Apr 3, 2023
* move performance now to run time dep (#309)

* move performance now to run time dep

Signed-off-by: Derek Ho <dxho@amazon.com>

* update release notes for this PR and CI fix PR

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit c046499)

* remove duplicate jest-dom

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updated snapshots for notebooks

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
derek-ho added a commit to derek-ho/dashboards-observability that referenced this pull request Apr 5, 2023
…ect#309) (opensearch-project#311)

* move performance now to run time dep (opensearch-project#309)

* move performance now to run time dep

Signed-off-by: Derek Ho <dxho@amazon.com>

* update release notes for this PR and CI fix PR

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit c046499)

* remove duplicate jest-dom

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updated snapshots for notebooks

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…arch-project#310)

* move performance now to run time dep

* update release notes for this PR and CI fix PR

---------

(cherry picked from commit c046499)

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit cdb18d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants