Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalog cache and Session update for async queries #1500

Merged
merged 5 commits into from
Mar 8, 2024

added polling result type, updated version constant

8ce818d
Select commit
Loading
Failed to load commit list.
Merged

Catalog cache and Session update for async queries #1500

added polling result type, updated version constant
8ce818d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 8, 2024 in 0s

54.39% (+0.13%) compared to 290415a

View this Pull Request on Codecov

54.39% (+0.13%) compared to 290415a

Details

Codecov Report

Attention: Patch coverage is 55.55556% with 96 lines in your changes are missing coverage. Please review.

Project coverage is 54.39%. Comparing base (290415a) to head (8ce818d).
Report is 1 commits behind head on main.

Files Patch % Lines
public/framework/catalog_cache/cache_loader.tsx 30.70% 79 Missing ⚠️
public/framework/catalog_cache/cache_intercept.ts 0.00% 7 Missing ⚠️
common/utils/shared.ts 61.53% 5 Missing ⚠️
common/utils/query_session_utils.ts 50.00% 2 Missing ⚠️
public/components/common/search/direct_search.tsx 0.00% 2 Missing ⚠️
public/plugin.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
+ Coverage   54.26%   54.39%   +0.13%     
==========================================
  Files         343      347       +4     
  Lines       12338    12563     +225     
  Branches     3173     3213      +40     
==========================================
+ Hits         6695     6834     +139     
- Misses       5587     5673      +86     
  Partials       56       56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov