Catalog cache and Session update for async queries #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
+ Coverage 54.26% 54.39% +0.13%
==========================================
Files 343 347 +4
Lines 12338 12563 +225
Branches 3173 3213 +40
==========================================
+ Hits 6695 6834 +139
- Misses 5587 5673 +86
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swiddis
reviewed
Mar 8, 2024
|
|
||
| const cachedDatabase = cachedDataSource.databases.find((db) => db.name === databaseName); | ||
| if (!cachedDatabase) { | ||
| throw new Error('Database not found exception: ' + databaseName); |
There was a problem hiding this comment.
From an API usability standpoint, I wonder if it's good design to throw an error on a cache miss. Since it's a pretty regular and probably expected occurrence, it might make more sense to return a CachedDatabase | null (or reuse the ok: boolean pattern from AsyncApiResponse) so TypeScript can do more heavy lifting for soundness checking.
There was a problem hiding this comment.
This is by design right now. We want the cache users to know where the get request is failing. I'll check with @RyanL1997 @sejli what do they expect thrown error or an error response. I remember UI having special cases where they see something missing with toast errors or callouts.
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
paulstn
reviewed
Mar 8, 2024
Swiddis
approved these changes
Mar 8, 2024
paulstn
approved these changes
Mar 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
* init commit for cache Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * cache loader init Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update cache with accelerations cache, add custom hooks Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add session coupling and fix tests for cache Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * added polling result type, updated version constant Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 943126f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
pushed a commit
that referenced
this pull request
Mar 9, 2024
* init commit for cache * cache loader init * update cache with accelerations cache, add custom hooks * add session coupling and fix tests for cache * added polling result type, updated version constant --------- (cherry picked from commit 943126f) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…t#1500) (opensearch-project#1504) * init commit for cache * cache loader init * update cache with accelerations cache, add custom hooks * add session coupling and fix tests for cache * added polling result type, updated version constant --------- (cherry picked from commit 943126f) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit b4c04d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catalog cache and Session update for async queries
Issues Resolved
#1484
#1251
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.