[Backport] Initialize the leaderCheckpoint with follower shard's localCheckpoint… #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
…opensearch-project#904) Signed-off-by: Ankit Kala <ankikala@amazon.com>
saikaranam-amazon
approved these changes
Jun 2, 2023
Codecov Report
@@ Coverage Diff @@
## 2.3 #965 +/- ##
============================================
+ Coverage 72.76% 73.29% +0.52%
- Complexity 999 1002 +3
============================================
Files 141 141
Lines 4689 4710 +21
Branches 522 523 +1
============================================
+ Hits 3412 3452 +40
+ Misses 951 934 -17
+ Partials 326 324 -2
|
monusingh-1
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#904)
Original PR: https://github.com/opensearch-project/cross-cluster-replication/pull/904/files
Also, this change is not merged in
2.*branches which needs to be picked as well: #438Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.