generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 76
Fixing the follower checkpoint updation in follower stats API #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soosinha
reviewed
Jul 1, 2022
src/test/kotlin/org/opensearch/replication/task/shard/TranslogSequencerTests.kt
Outdated
Show resolved
Hide resolved
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
soosinha
approved these changes
Jul 1, 2022
ankitkala
approved these changes
Jul 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1 1.1
# Navigate to the new working tree
cd .worktrees/backport-1.1
# Create a new branch
git switch --create backport/backport-438-to-1.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6130d6feda5075a695bc384b2702a76d4db383a6
# Push it to GitHub
git push --set-upstream origin backport/backport-438-to-1.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 6130d6f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 6130d6f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 6130d6f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 6130d6f)
gbbafna
added a commit
that referenced
this pull request
Jul 7, 2022
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 6130d6f) Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
gbbafna
added a commit
that referenced
this pull request
Jul 7, 2022
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 6130d6f) Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
gbbafna
added a commit
to gbbafna/cross-cluster-replication
that referenced
this pull request
Jul 8, 2022
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
added a commit
that referenced
this pull request
Jul 8, 2022
gbbafna
added a commit
to gbbafna/cross-cluster-replication
that referenced
this pull request
Jul 8, 2022
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
added a commit
to gbbafna/cross-cluster-replication
that referenced
this pull request
Aug 23, 2022
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
added a commit
to gbbafna/cross-cluster-replication
that referenced
this pull request
Aug 23, 2022
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
added a commit
to gbbafna/cross-cluster-replication
that referenced
this pull request
Aug 23, 2022
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
added a commit
to gbbafna/cross-cluster-replication
that referenced
this pull request
Aug 23, 2022
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
added a commit
that referenced
this pull request
Aug 23, 2022
gbbafna
added a commit
that referenced
this pull request
Aug 23, 2022
gbbafna
added a commit
that referenced
this pull request
Aug 26, 2022
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 6130d6f) Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
gbbafna
added a commit
that referenced
this pull request
Aug 26, 2022
saikaranam-amazon
pushed a commit
that referenced
this pull request
Dec 27, 2022
ankitkala
pushed a commit
to ankitkala/cross-cluster-replication
that referenced
this pull request
Jun 2, 2023
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
5 tasks
ankitkala
pushed a commit
that referenced
this pull request
Jun 2, 2023
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
ankitkala
pushed a commit
to ankitkala/cross-cluster-replication
that referenced
this pull request
Jun 2, 2023
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
ankitkala
pushed a commit
to ankitkala/cross-cluster-replication
that referenced
this pull request
Jun 2, 2023
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
ankitkala
pushed a commit
to ankitkala/cross-cluster-replication
that referenced
this pull request
Jun 2, 2023
…oject#438) Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
This was referenced Jun 2, 2023
ankitkala
pushed a commit
that referenced
this pull request
Jun 2, 2023
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
ankitkala
pushed a commit
that referenced
this pull request
Jun 2, 2023
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
ankitkala
pushed a commit
that referenced
this pull request
Jun 2, 2023
Summary : We need to update followerCheckpoint after writing to the follower index. Currently, we are not waiting for the writes and updating it with soon-to-be stale values Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary : We need to update followerCheckpoint after writing to the follower index.
Currently, we are not waiting for the writes and updating it with soon-to-be stale values
Signed-off-by: Gaurav Bafna gbbafna@amazon.com
Description
Correctly updating follower_stats at two places :
Issues Resolved
431
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.