Adding Index Settings validation before starting replication #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
============================================
- Coverage 74.52% 72.54% -1.98%
+ Complexity 1002 985 -17
============================================
Files 141 141
Lines 4565 4579 +14
Branches 504 506 +2
============================================
- Hits 3402 3322 -80
- Misses 847 937 +90
- Partials 316 320 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
soosinha
previously approved these changes
Jul 25, 2022
| .build() | ||
|
|
||
| assertThatThrownBy { | ||
| followerClient.startReplication(StartReplicationRequest("source", leaderIndexName, followerIndexName, settings = settings)) |
There was a problem hiding this comment.
Can we validated status code as well?
| overriddenSettings: Settings, | ||
| metadataCreateIndexService: MetadataCreateIndexService | ||
| ) { | ||
| val settingsList = arrayOf(leaderSettings, overriddenSettings) |
There was a problem hiding this comment.
Please validate to see if the behavior is as expected, due to open bug on replication side: #298?
There was a problem hiding this comment.
I have fixed this bug in this PR as well. Now we are retrieving the default settings as well .
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
force-pushed
the
setting-validate
branch
from
6fb72bf to
afb9fbb
Compare
saikaranam-amazon
approved these changes
Aug 3, 2022
soosinha
approved these changes
Aug 3, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
* Adding Index Settings validation before starting replication Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Retrieving default index settings before starting replication Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 93b43f4)
gbbafna
added a commit
that referenced
this pull request
Aug 3, 2022
…470) * Adding Index Settings validation before starting replication Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Retrieving default index settings before starting replication Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 93b43f4) Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaurav Bafna gbbafna@amazon.com
Description
Before starting the replication , we need to validate for correctness of index settings. This would throw validation exception before starting replication itself.
If not done, the snapshot restore phase of replication will fail asynchronously and customer would need to stop and start the replication again without error message being communicated .
Issues Resolved
#460
#298
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.