Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the zip dependency for bwc tests. #366

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

naveenpajjuri
Copy link
Contributor

@naveenpajjuri naveenpajjuri commented Apr 15, 2022

Signed-off-by: Naveen Pajjuri nppajjur@amazon.com

Description

Setup a BWC task to pull the OpenSeacrh release artifact and extract a zip of the ccr plugin (addressing #335).

Issues Resolved

#335

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naveen Pajjuri <nppajjur@amazon.com>
@naveenpajjuri naveenpajjuri requested a review from a team April 15, 2022 06:25
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #366 (5a5d104) into main (9073e63) will increase coverage by 0.59%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #366      +/-   ##
============================================
+ Coverage     74.05%   74.64%   +0.59%     
- Complexity      994      998       +4     
============================================
  Files           141      141              
  Lines          4544     4544              
  Branches        501      501              
============================================
+ Hits           3365     3392      +27     
+ Misses          860      838      -22     
+ Partials        319      314       -5     
Impacted Files Coverage Δ
...rch/replication/task/shard/ShardReplicationTask.kt 75.18% <0.00%> (-0.73%) ⬇️
...earch/replication/metadata/UpdateIndexBlockTask.kt 77.41% <0.00%> (+3.22%) ⬆️
...action/stop/TransportStopIndexReplicationAction.kt 74.66% <0.00%> (+5.33%) ⬆️
...rch/replication/action/status/ShardInfoResponse.kt 91.59% <0.00%> (+19.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9073e63...5a5d104. Read the comment docs.

@naveenpajjuri naveenpajjuri merged commit 1231c1b into opensearch-project:main Apr 15, 2022
@dblock
Copy link
Member

dblock commented Apr 18, 2022

I've opened opensearch-project/OpenSearch#2950 to extract this boilerplate into an OpenSearch build gradle task. Feel free to contribute that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants