Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace opendistro-alerting-1.13.1.0.zip with an external download #350

Closed
Tracked by #1750
dblock opened this issue Mar 14, 2022 · 3 comments
Closed
Tracked by #1750

Replace opendistro-alerting-1.13.1.0.zip with an external download #350

dblock opened this issue Mar 14, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@dblock
Copy link
Member

dblock commented Mar 14, 2022

Coming from opensearch-project/opensearch-build#1750, replace the checked in alerting/alerting/src/test/resources/bwc/alerting/1.13.1.0/opendistro-alerting-1.13.1.0.zip with an external download during bwc test if it's still used.

@lezzago
Copy link
Member

lezzago commented Apr 11, 2022

This would also need change the notification zips to be retrieved for an external download. This is going to be difficult currently since these zips will need to be the latest versions of the notification zips as the version gets bumped over time.

@dblock
Copy link
Member Author

dblock commented Apr 18, 2022

@lezzago Is this more complicated than opensearch-project/cross-cluster-replication#366 or opensearch-project/sql#514? We now have latest supported in URLs.

@qreshi
Copy link
Contributor

qreshi commented Apr 27, 2022

PR has been merged and backported to 2.0 branch as well. Closing.

@qreshi qreshi closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants