Remove rc1 qualifier

[amitgalitz]

Description

remove rc1 qualifier

Issues Resolved

resolves #254

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #257 (339951f) into main (74b644c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   45.92%   45.92%           
=======================================
  Files         150      150           
  Lines        4956     4956           
  Branches      955      968   +13     
=======================================
  Hits         2276     2276           
  Misses       2463     2463           
  Partials      217      217           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b644c...339951f. Read the comment docs.

[Zhangxunmt]

Is this supposed to target only for 2.0 branch?

[amitgalitz]

Is this supposed to target only for 2.0 branch?

same as answer on backend, from my understanding we want to keep main most up to date and then backport change to 2.0 branch

[amitgalitz]

So currently remote integ CI is failing due to ftrepo using the github branch of the test library instead of the npm package. opensearch-project/opensearch-dashboards-functional-test#222. This is currently blocking our PR to remove rc1 from AD-dashboards. @kavilla are we confident enough this is the cause so its okay to merge this PR for now or anyways this will fail on Jenkins so might as well wait?

[ohltyler]

LGTM! Let's follow up with the failed integ test in FTRepo as its known to just be a flaky one.

[amitgalitz]

Failing test on CI seems to be flaky as it passes locally. I also have a PR out to fix the test on FTRepo opensearch-project/opensearch-dashboards-functional-test#227. I suggest we merge this PR in the meantime as it doesn't have any breaking changes itself.