Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimist from 1.2.5 to 1.2.6 #219

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 29, 2022

Bumps minimist from 1.2.5 to 1.2.6.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team March 29, 2022 15:13
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #219 (f9bb97f) into main (39086ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   45.90%   45.90%           
=======================================
  Files         150      150           
  Lines        4956     4956           
  Branches      955      955           
=======================================
  Hits         2275     2275           
  Misses       2463     2463           
  Partials      218      218           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39086ba...f9bb97f. Read the comment docs.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 7, 2022

Dependabot attempted to update this pull request, but because the branch dependabot/npm_and_yarn/minimist-1.2.6 is protected it was unable to do so.

@amitgalitz
Copy link
Member

amitgalitz commented May 12, 2022

@ohltyler this was merged on OSD (opensearch-project/OpenSearch-Dashboards#1377) as well to resolve this CVE. I think it makes sense to approve and merge

update--> actually since we use this dependency from core shouldn't this be not needed on our side?

@ohltyler
Copy link
Member

@ohltyler this was merged on OSD (opensearch-project/OpenSearch-Dashboards#1377) as well to resolve this CVE. I think it makes sense to approve and merge

update--> actually since we use this dependency from core shouldn't this be not needed on our side?

dependabot doesn't take into account the dependencies from OSD in yarn.lock - in other words, when running yarn osd bootstrap in a nested dev env where OSD is a parent project, it pulls in those dependencies as well.

Thus these PRs are never good to manually merge. If fixed by OSD then running yarn osd bootstrap again should update the yarn.lock here and resolve the CVE.

@amitgalitz
Copy link
Member

@ohltyler this was merged on OSD (opensearch-project/OpenSearch-Dashboards#1377) as well to resolve this CVE. I think it makes sense to approve and merge
update--> actually since we use this dependency from core shouldn't this be not needed on our side?

dependabot doesn't take into account the dependencies from OSD in yarn.lock - in other words, when running yarn osd bootstrap in a nested dev env where OSD is a parent project, it pulls in those dependencies as well.

Thus these PRs are never good to manually merge. If fixed by OSD then running yarn osd bootstrap again should update the yarn.lock here and resolve the CVE.

I actually did this and didn't see a yarn.lock change. After your comment I deleted yarn.lock and ran it again and it pulled latest changes

@amitgalitz
Copy link
Member

closing, change will be merged in with this PR: #257

@amitgalitz amitgalitz closed this May 12, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 12, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@ohltyler ohltyler deleted the dependabot/npm_and_yarn/minimist-1.2.6 branch September 11, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants