Fix NPE for non-vis embeddables on dashboards #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago
requested review from
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
Codecov Report
@@ Coverage Diff @@
## main #682 +/- ##
=======================================
Coverage 49.87% 49.87%
=======================================
Files 233 233
Lines 6567 6567
Branches 938 938
=======================================
Hits 3275 3275
Misses 3289 3289
Partials 3 3 |
bowenlan-amzn
approved these changes
Aug 10, 2023
AWSHurneyt
approved these changes
Aug 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 8fcf14c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Aug 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 8fcf14c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
lezzago
pushed a commit
that referenced
this pull request
Aug 10, 2023
(cherry picked from commit 8fcf14c) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
lezzago
pushed a commit
that referenced
this pull request
Aug 10, 2023
(cherry picked from commit 8fcf14c) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix NPE for non-vis embeddables on dashboards
Issues Resolved
opensearch-project/OpenSearch-Dashboards#4688
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.