Skip to content

Commit

Permalink
Fix NPE for non-vis embeddables on dashboards (#682)
Browse files Browse the repository at this point in the history
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 8fcf14c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
github-actions[bot] committed Aug 10, 2023
1 parent 3e96185 commit 8164487
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion public/actions/alerting_dashboard_action.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,13 @@ export const createAlertingAction = ({
getIconType: () => icon,
type,
grouping,
// Do not show actions for certin visualizations
// Do not show actions for certain visualizations
isCompatible: async ({ embeddable }: ActionContext) => {
return Boolean(
embeddable.parent &&
embeddable.getInput()?.viewMode === 'view' &&
isDashboard(embeddable.parent) &&
embeddable.vis &&
isEligibleForVisLayers(embeddable.vis, getUISettings())
);
},
Expand Down

0 comments on commit 8164487

Please sign in to comment.