-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport][1.0] Version checks are incorrectly returning versions < 1.0.0. (#797) #808
Conversation
…h-project#797) * Version checks are incorrectly returning versions < 1.0.0. Signed-off-by: dblock <dblock@amazon.com> * Removed V_7_10_3 which has not been released as of time of the fork. Signed-off-by: dblock <dblock@amazon.com> * Update check for current version to get unreleased versions. - no unreleased version if the current version is "1.0.0" - add unit tests for OpenSearch 1.0.0 with legacy ES versions. - update VersionUtils to include all legacy ES versions as released. Signed-off-by: Rabi Panda <adnapibar@gmail.com> Co-authored-by: Rabi Panda <adnapibar@gmail.com>
✅ DCO Check Passed 5153f0a |
✅ Gradle Wrapper Validation success 5153f0a |
✅ Gradle Precommit success 5153f0a |
Don't think it's necessary, it's only required for running the bwc tests. |
Why don't you think we'll want to run that on 1.0 before release/security fixes in the future? |
You're right. We'll regret it probably, but I'll close this for now :) |
) * Bump com.diffplug.spotless from 6.23.3 to 6.24.0 Bumps com.diffplug.spotless from 6.23.3 to 6.24.0. --- updated-dependencies: - dependency-name: com.diffplug.spotless dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Backport #797 into 1.0. Do we want this here?