Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][1.0] Version checks are incorrectly returning versions < 1.0.0. (#797) #808

Closed
wants to merge 1 commit into from

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 2, 2021

Backport #797 into 1.0. Do we want this here?

…h-project#797)

* Version checks are incorrectly returning versions < 1.0.0.

Signed-off-by: dblock <dblock@amazon.com>

* Removed V_7_10_3 which has not been released as of time of the fork.

Signed-off-by: dblock <dblock@amazon.com>

* Update check for current version to get unreleased versions.

- no unreleased version if the current version is "1.0.0"
- add unit tests for OpenSearch 1.0.0 with legacy ES versions.
- update VersionUtils to include all legacy ES versions as released.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Co-authored-by: Rabi Panda <adnapibar@gmail.com>
@dblock dblock requested a review from adnapibar June 2, 2021 20:23
@dblock dblock added backport PRs or issues specific to backporting features or enhancments v1.0.0 Version 1.0.0 labels Jun 2, 2021
@dblock dblock changed the title Version checks are incorrectly returning versions < 1.0.0. (#797) [Backport][1.0] Version checks are incorrectly returning versions < 1.0.0. (#797) Jun 2, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 5153f0a

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 5153f0a

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 5153f0a

@adnapibar
Copy link
Contributor

Backport #797 into 1.0. Do we want this here?

Don't think it's necessary, it's only required for running the bwc tests.

@dblock
Copy link
Member Author

dblock commented Jun 3, 2021

Backport #797 into 1.0. Do we want this here?

Don't think it's necessary, it's only required for running the bwc tests.

Why don't you think we'll want to run that on 1.0 before release/security fixes in the future?

@adnapibar
Copy link
Contributor

Backport #797 into 1.0. Do we want this here?

Don't think it's necessary, it's only required for running the bwc tests.

Why don't you think we'll want to run that on 1.0 before release/security fixes in the future?

I thought we decided to run the BWC tests on main and 1.x only (#798) ?

@dblock
Copy link
Member Author

dblock commented Jun 3, 2021

Backport #797 into 1.0. Do we want this here?

Don't think it's necessary, it's only required for running the bwc tests.

Why don't you think we'll want to run that on 1.0 before release/security fixes in the future?

I thought we decided to run the BWC tests on main and 1.x only (#798) ?

You're right. We'll regret it probably, but I'll close this for now :)

@dblock dblock closed this Jun 3, 2021
ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024
)

* Bump com.diffplug.spotless from 6.23.3 to 6.24.0

Bumps com.diffplug.spotless from 6.23.3 to 6.24.0.

---
updated-dependencies:
- dependency-name: com.diffplug.spotless
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments v1.0.0 Version 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants