Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run gradle checks on 1.x #798

Closed
dblock opened this issue May 28, 2021 · 6 comments
Closed

Run gradle checks on 1.x #798

dblock opened this issue May 28, 2021 · 6 comments
Assignees
Labels
CI CI related enhancement Enhancement or improvement to existing feature or request v1.1.0 Issues, PRs, related to the 1.1.0 release

Comments

@dblock
Copy link
Member

dblock commented May 28, 2021

Is your feature request related to a problem? Please describe.

We need to be running CI on main, and 1.xm, as they will be diverging (1.x will be 1.1 and main will be 2.0), including backward compatibility tests. In the future we'll want CI to automatically start running on 2.x.

Describe the solution you'd like

Make CI on main = CI on 1.x.

@dblock dblock added enhancement Enhancement or improvement to existing feature or request CI CI related v1.1.0 Issues, PRs, related to the 1.1.0 release labels May 28, 2021
@adnapibar
Copy link
Contributor

Can the CI be configured to run on any branch in addition to main that ends with .x so we don't have to keep creating issues to enable CI in 2.x, 3.x ... ?

@dblock
Copy link
Member Author

dblock commented Jun 3, 2021

@bbarani

@dblock
Copy link
Member Author

dblock commented Jul 16, 2021

This has a corresponding opensearch-project/opensearch-build#39.

@mch2
Copy link
Member

mch2 commented Sep 7, 2021

I believe this can be closed as a duplicate to opensearch-project/opensearch-build#350.

@dblock am I off here? was this ticket specific to gradle checks?

@dblock dblock changed the title Run CI on 1.x Run gradle checks on 1.x Sep 8, 2021
@dblock
Copy link
Member Author

dblock commented Sep 8, 2021

I've renamed to "run gradle checks on 1.x"

@mch2
Copy link
Member

mch2 commented Sep 8, 2021

I think we can close this issue - gradle checks currently run for any branch as long as 'start gradle check' comment is made on the PR.

I've opened a separate issue to make the gradle check job public.
We also have an existing issue for setting up randomized testing that will be branch specific.

@mch2 mch2 closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related enhancement Enhancement or improvement to existing feature or request v1.1.0 Issues, PRs, related to the 1.1.0 release
Projects
None yet
Development

No branches or pull requests

4 participants