Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add dynamic index and cluster setting for concurrent segment search #8034

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Jun 12, 2023

Add dynamic index and cluster setting for concurrent segment search (#7956)

  • Add dynamic index and cluster setting for concurrent segment search
  • Use feature flagged settings map

Related Issues

Resolves #7356

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jed326
Copy link
Collaborator Author

jed326 commented Jun 12, 2023

@reta Here is the backport PR for #7956. Thank you!

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…pensearch-project#7956)

* Add dynamic index and cluster setting for concurrent segment search

Signed-off-by: Jay Deng <jayd0104@gmail.com>

* Use feature flagged settings map

Signed-off-by: Jay Deng <jayd0104@gmail.com>

---------

Signed-off-by: Jay Deng <jayd0104@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #8034 (de25df2) into 2.x (55bb8f3) will decrease coverage by 0.04%.
The diff coverage is 91.42%.

@@             Coverage Diff              @@
##                2.x    #8034      +/-   ##
============================================
- Coverage     70.63%   70.59%   -0.04%     
+ Complexity    56661    56641      -20     
============================================
  Files          4695     4696       +1     
  Lines        268477   268499      +22     
  Branches      39699    39700       +1     
============================================
- Hits         189642   189554      -88     
- Misses        62558    62587      +29     
- Partials      16277    16358      +81     
Impacted Files Coverage Δ
.../org/opensearch/search/internal/SearchContext.java 36.36% <0.00%> (-0.85%) ⬇️
...va/org/opensearch/search/DefaultSearchContext.java 78.57% <75.00%> (-0.12%) ⬇️
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <100.00%> (+0.35%) ⬆️
...pensearch/common/settings/IndexScopedSettings.java 100.00% <100.00%> (ø)
.../main/java/org/opensearch/index/IndexSettings.java 86.95% <100.00%> (+0.06%) ⬆️
.../main/java/org/opensearch/search/SearchModule.java 97.53% <100.00%> (-0.02%) ⬇️
...main/java/org/opensearch/search/SearchService.java 72.39% <100.00%> (+0.79%) ⬆️
...rch/search/query/ConcurrentQueryPhaseSearcher.java 75.00% <100.00%> (+5.30%) ⬆️
...search/search/query/QueryPhaseSearcherWrapper.java 100.00% <100.00%> (ø)

... and 482 files with indirect coverage changes

@reta reta merged commit c83c683 into opensearch-project:2.x Jun 13, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…pensearch-project#7956) (opensearch-project#8034)

* Add dynamic index and cluster setting for concurrent segment search



* Use feature flagged settings map



---------

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants